blaginin commented on code in PR #15937:
URL: https://github.com/apache/datafusion/pull/15937#discussion_r2072657525
##
datafusion/optimizer/src/propagate_empty_relation.rs:
##
@@ -280,8 +291,7 @@ mod tests {
.project(vec![binary_expr(lit(1), Operator::Plus, lit(1))
qstommyshu commented on code in PR #15937:
URL: https://github.com/apache/datafusion/pull/15937#discussion_r2072659106
##
datafusion/optimizer/src/propagate_empty_relation.rs:
##
@@ -280,8 +291,7 @@ mod tests {
.project(vec![binary_expr(lit(1), Operator::Plus, lit(1
qstommyshu commented on code in PR #15937:
URL: https://github.com/apache/datafusion/pull/15937#discussion_r2072659106
##
datafusion/optimizer/src/propagate_empty_relation.rs:
##
@@ -280,8 +291,7 @@ mod tests {
.project(vec![binary_expr(lit(1), Operator::Plus, lit(1
qstommyshu commented on code in PR #15937:
URL: https://github.com/apache/datafusion/pull/15937#discussion_r2072659106
##
datafusion/optimizer/src/propagate_empty_relation.rs:
##
@@ -280,8 +291,7 @@ mod tests {
.project(vec![binary_expr(lit(1), Operator::Plus, lit(1
acking-you commented on PR #15913:
URL: https://github.com/apache/datafusion/pull/15913#issuecomment-2849308320
Thank you for your code review, @alamb. I've added more performance test
cases!
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2849308705
> Could you please refer to the error lints in CI? Such as
>
> ```
> error[E0433]: failed to resolve: use of undeclared type `Statistics`
> --> datafusion/core/src/lib.r
Adez017 commented on PR #15778:
URL: https://github.com/apache/datafusion/pull/15778#issuecomment-2849310226
hi @alamb @xudong963 i think its not a big PR to deal with , it just need
a small inspection and it would be helpful do deal with it . Thank you
--
This is an automated messag
qstommyshu commented on code in PR #15937:
URL: https://github.com/apache/datafusion/pull/15937#discussion_r2072660969
##
datafusion/optimizer/src/test/mod.rs:
##
@@ -242,6 +226,24 @@ pub fn assert_optimized_plan_eq_display_indent(
assert_eq!(formatted_plan, expected);
}
qstommyshu commented on code in PR #15937:
URL: https://github.com/apache/datafusion/pull/15937#discussion_r2072661482
##
datafusion/optimizer/src/test/mod.rs:
##
@@ -242,6 +226,24 @@ pub fn assert_optimized_plan_eq_display_indent(
assert_eq!(formatted_plan, expected);
}
qstommyshu commented on code in PR #15937:
URL: https://github.com/apache/datafusion/pull/15937#discussion_r2072661482
##
datafusion/optimizer/src/test/mod.rs:
##
@@ -242,6 +226,24 @@ pub fn assert_optimized_plan_eq_display_indent(
assert_eq!(formatted_plan, expected);
}
iffyio commented on code in PR #1809:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1809#discussion_r2072719447
##
src/parser/mod.rs:
##
@@ -475,6 +475,10 @@ impl<'a> Parser<'a> {
if expecting_statement_delimiter && word.keyword ==
Keyword::E
MohamedAbdeen21 commented on code in PR #1835:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1835#discussion_r2072717456
##
src/tokenizer.rs:
##
@@ -1281,20 +1262,91 @@ impl<'a> Tokenizer<'a> {
return Ok(Some(Token::make_word(s.as_
iffyio merged PR #1830:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
iffyio commented on PR #1834:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1834#issuecomment-2849446927
@aharpervc could you take a look at this PR, it seems to have commits from
other PRs like the CREATE TRIGGER in it, so hard to tell what's being
introduced this one
--
iffyio commented on code in PR #1826:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1826#discussion_r2072720003
##
src/parser/mod.rs:
##
@@ -5199,13 +5199,20 @@ impl<'a> Parser<'a> {
// parse: [ argname ] argtype
let mut name = None;
+l
xudong963 commented on PR #15937:
URL: https://github.com/apache/datafusion/pull/15937#issuecomment-2849853927
Thank you all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
xudong963 merged PR #15937:
URL: https://github.com/apache/datafusion/pull/15937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
xudong963 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2849865580
> Thanks, mate, but I think it shows for the `lib.rs` file, and we didn't
make any changes there. Does this mean that we need to change over there?
If you take a look at the
PokIsemaine commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2072647351
##
datafusion/sql/src/expr/order_by.rs:
##
@@ -61,13 +57,27 @@ impl SqlToRel<'_, S> {
None => input_schema,
};
-let mut expr_ve
hsiang-c opened a new pull request, #1715:
URL: https://github.com/apache/datafusion-comet/pull/1715
## Which issue does this PR close?
Closes #. https://github.com/apache/datafusion-comet/issues/1685
## Rationale for this change
Run Iceberg Spark' tests a
hsiang-c commented on code in PR #1715:
URL: https://github.com/apache/datafusion-comet/pull/1715#discussion_r2072756448
##
.github/workflows/iceberg_spark_test.yml:
##
@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
hsiang-c commented on code in PR #1715:
URL: https://github.com/apache/datafusion-comet/pull/1715#discussion_r2072756556
##
.github/actions/setup-iceberg-builder/action.yaml:
##
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
irenjj commented on issue #15916:
URL: https://github.com/apache/datafusion/issues/15916#issuecomment-2849729993
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
mixermt commented on issue #1714:
URL:
https://github.com/apache/datafusion-comet/issues/1714#issuecomment-2849234775
Now I see that the failure occurred in a specific job from our regression
set.
I will try re-play it multiple times to narrow down the issue.
--
This is an automated
xudong963 commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2072637668
##
datafusion/sql/src/expr/order_by.rs:
##
@@ -61,13 +57,27 @@ impl SqlToRel<'_, S> {
None => input_schema,
};
-let mut expr_vec
xudong963 commented on code in PR #15772:
URL: https://github.com/apache/datafusion/pull/15772#discussion_r2072637962
##
datafusion/sql/src/expr/order_by.rs:
##
@@ -61,13 +57,27 @@ impl SqlToRel<'_, S> {
None => input_schema,
};
-let mut expr_vec
xudong963 commented on issue #15934:
URL: https://github.com/apache/datafusion/issues/15934#issuecomment-2849263595
I notice we don't have the least tpc-ds tests in sqllogictest, maybe it's
better to add them
--
This is an automated message from the Apache Git Service.
To respond to the m
xudong963 commented on issue #15885:
URL: https://github.com/apache/datafusion/issues/15885#issuecomment-2849264701
> > > not sure if it will help direction, cost nothing to share :)
[Debunking the Myth of Join Ordering: Toward Robust SQL
Analytics](https://arxiv.org/abs/2502.15181)
> >
iffyio commented on code in PR #1835:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1835#discussion_r2072716889
##
src/tokenizer.rs:
##
@@ -1281,20 +1262,91 @@ impl<'a> Tokenizer<'a> {
return Ok(Some(Token::make_word(s.as_str(),
N
NevroHelios commented on PR #15841:
URL: https://github.com/apache/datafusion/pull/15841#issuecomment-2849377862
Is there anything else I am missing or need to add? @alamb @xudong963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
mixermt opened a new issue, #1714:
URL: https://github.com/apache/datafusion-comet/issues/1714
Hi,
Experience occasional failure of Spark executors
```
│ # A fatal error has been detected by the Java Runtime Environment:
xudong963 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2849259474
Could you please refer to the error lints in CI? Such as
```
error[E0433]: failed to resolve: use of undeclared type `Statistics`
--> datafusion/core/src/lib.rs:1365:12
codecov-commenter commented on PR #1710:
URL:
https://github.com/apache/datafusion-comet/pull/1710#issuecomment-2849378438
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
juju4 commented on issue #15872:
URL: https://github.com/apache/datafusion/issues/15872#issuecomment-2849384492
ah, regexp_like() is good. Thanks @Omega359
But it makes me confused why some functions works in both select and where
(regexp_like) and some not (regexp_match, probably others
GitHub user juju4 added a comment to the discussion: outlier, time compare or
frequency analysis operators in datafusion?
so best approaching that is currently available is standard deviation (stddev),
correct?
https://datafusion.apache.org/user-guide/sql/aggregate_functions.html#stddev
GitHu
mixermt commented on issue #1714:
URL:
https://github.com/apache/datafusion-comet/issues/1714#issuecomment-2849354985
Another observation, failure happens while read of data from Iceberg table.
Either we have some versions mismatch, jar hell or some other still unknown
reason to me
blaginin commented on code in PR #15937:
URL: https://github.com/apache/datafusion/pull/15937#discussion_r2072785654
##
datafusion/optimizer/src/test/mod.rs:
##
@@ -242,6 +226,24 @@ pub fn assert_optimized_plan_eq_display_indent(
assert_eq!(formatted_plan, expected);
}
+
blaginin commented on code in PR #15937:
URL: https://github.com/apache/datafusion/pull/15937#discussion_r2072785470
##
datafusion/optimizer/src/propagate_empty_relation.rs:
##
@@ -280,8 +291,7 @@ mod tests {
.project(vec