Re: [I] Support exposing setting memory limit of memory pool [datafusion]

2025-04-23 Thread via GitHub
Rachelint closed issue #15830: Support exposing setting memory limit of memory pool URL: https://github.com/apache/datafusion/issues/15830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] Minor: cleanup hash table after emit all [datafusion]

2025-04-23 Thread via GitHub
jayzhan211 opened a new pull request, #15834: URL: https://github.com/apache/datafusion/pull/15834 ## Which issue does this PR close? - Closes #. ## Rationale for this change ## What changes are included in this PR? ## Are these changes test

Re: [PR] feat: More warning info for users [datafusion-comet]

2025-04-23 Thread via GitHub
parthchandra commented on code in PR #1667: URL: https://github.com/apache/datafusion-comet/pull/1667#discussion_r2056942543 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -161,10 +161,28 @@ class CometSparkSessionExtensions }

Re: [PR] feat: support `array_repeat` [datafusion-comet]

2025-04-23 Thread via GitHub
comphead commented on PR #1680: URL: https://github.com/apache/datafusion-comet/pull/1680#issuecomment-2825758696 Now problem DF and Spark returns different value if count is null DF returns empty array ``` > select array_repeat(null, arrow_cast(null, 'Int32')); +---

[PR] feat: support `array_repeat` [datafusion-comet]

2025-04-23 Thread via GitHub
comphead opened a new pull request, #1680: URL: https://github.com/apache/datafusion-comet/pull/1680 ## Which issue does this PR close? Replaces #1205 . Closes #1347 ## Rationale for this change ## What changes are included in this PR?

Re: [PR] docs: Add changelog for 0.8.0 [datafusion-comet]

2025-04-23 Thread via GitHub
andygrove merged PR #1675: URL: https://github.com/apache/datafusion-comet/pull/1675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] Add `CREATE TRIGGER` support for SQL Server [datafusion-sqlparser-rs]

2025-04-23 Thread via GitHub
aharpervc commented on PR #1810: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1810#issuecomment-2825353800 Rebased again now that https://github.com/apache/datafusion-sqlparser-rs/pull/1808 has been merged. Should be ready for review. -- This is an automated message from

Re: [PR] Add support for `GO` batch delimiter in SQL Server [datafusion-sqlparser-rs]

2025-04-23 Thread via GitHub
aharpervc commented on code in PR #1809: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1809#discussion_r2056927589 ## src/parser/mod.rs: ## @@ -618,6 +632,7 @@ impl<'a> Parser<'a> { // `COMMENT` is snowflake specific https://docs.snowflake.com/en

Re: [PR] Add support for `GO` batch delimiter in SQL Server [datafusion-sqlparser-rs]

2025-04-23 Thread via GitHub
aharpervc commented on code in PR #1809: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1809#discussion_r2056927872 ## src/parser/mod.rs: ## @@ -3939,6 +3954,26 @@ impl<'a> Parser<'a> { }) } +/// Return nth previous token, possibly whitespac

Re: [PR] Add support for `GO` batch delimiter in SQL Server [datafusion-sqlparser-rs]

2025-04-23 Thread via GitHub
aharpervc commented on code in PR #1809: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1809#discussion_r2056929658 ## src/parser/mod.rs: ## @@ -484,8 +488,18 @@ impl<'a> Parser<'a> { } let statement = self.parse_statement()?; +

Re: [PR] Add support for `GO` batch delimiter in SQL Server [datafusion-sqlparser-rs]

2025-04-23 Thread via GitHub
aharpervc commented on code in PR #1809: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1809#discussion_r2056934141 ## src/parser/mod.rs: ## @@ -484,8 +488,18 @@ impl<'a> Parser<'a> { } let statement = self.parse_statement()?; +

Re: [PR] Support WITHIN GROUP syntax to standardize certain existing aggregate functions [datafusion]

2025-04-23 Thread via GitHub
Garamda commented on PR #13511: URL: https://github.com/apache/datafusion/pull/13511#issuecomment-2826255767 @jayzhan211 Alright, I see. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Fix `ILIKE` expression support in SQL unparser [datafusion]

2025-04-23 Thread via GitHub
ewgenius commented on PR #15820: URL: https://github.com/apache/datafusion/pull/15820#issuecomment-2826267482 @comphead thanks for the response. The problem we faced at Spice is that `ILIKE` expression pushed down as `LIKE` to the data source: - https://github.com/spiceai/spiceai/i

Re: [PR] replace reassign_predicate_columns helper with PhysicalExpr::with_schema [datafusion]

2025-04-23 Thread via GitHub
adriangb commented on code in PR #15779: URL: https://github.com/apache/datafusion/pull/15779#discussion_r2057512794 ## datafusion/physical-expr-common/src/physical_expr.rs: ## @@ -333,6 +333,15 @@ pub trait PhysicalExpr: Send + Sync + Display + Debug + DynEq + DynHash {

Re: [PR] Update extending-operators.md [datafusion]

2025-04-23 Thread via GitHub
xudong963 commented on PR #15832: URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2826402327 > i want to ask that did we had to rewrite the part of code https://github.com/apache/datafusion/blob/main/datafusion/core/tests/user_defined/user_defined_plan.rs#L18-L24 afterward

Re: [PR] Fix: fetch is missing in `EnforceSorting` optimizer (two places) [datafusion]

2025-04-23 Thread via GitHub
xudong963 commented on code in PR #15822: URL: https://github.com/apache/datafusion/pull/15822#discussion_r2057547218 ## datafusion/physical-optimizer/src/enforce_sorting/replace_with_order_preserving_variants.rs: ## @@ -137,6 +137,12 @@ fn plan_with_order_preserving_variants(

Re: [PR] Update extending-operators.md [datafusion]

2025-04-23 Thread via GitHub
Adez017 commented on PR #15832: URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2826434082 > > i want to ask that did we had to rewrite the part of code https://github.com/apache/datafusion/blob/main/datafusion/core/tests/user_defined/user_defined_plan.rs#L18-L24 afterward

Re: [PR] Update extending-operators.md [datafusion]

2025-04-23 Thread via GitHub
xudong963 commented on PR #15832: URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2826449563 > > > i want to ask that did we had to rewrite the part of code https://github.com/apache/datafusion/blob/main/datafusion/core/tests/user_defined/user_defined_plan.rs#L18-L24 after

<    1   2