freshtonic commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1903356404
##
src/ast/mod.rs:
##
@@ -7278,16 +7279,126 @@ impl fmt::Display for SearchModifier {
}
}
+/// A `LOCK TABLE ..` statement. MySQL and Postgr
github-actions[bot] commented on PR #1470:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1470#issuecomment-2572020421
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or
goldmedal commented on PR #14004:
URL: https://github.com/apache/datafusion/pull/14004#issuecomment-2572104239
Thanks @milenkovicm and @alamb for the reviews 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
goldmedal closed issue #14003: Preserve session context id when
`ctx.enable_url_table()`
URL: https://github.com/apache/datafusion/issues/14003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
goldmedal merged PR #14004:
URL: https://github.com/apache/datafusion/pull/14004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
niebayes commented on PR #14000:
URL: https://github.com/apache/datafusion/pull/14000#issuecomment-2572119874
Great work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhuqi-lucas commented on code in PR #13996:
URL: https://github.com/apache/datafusion/pull/13996#discussion_r1903588409
##
benchmarks/src/h2o.rs:
##
@@ -0,0 +1,263 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See
zhuqi-lucas commented on code in PR #13996:
URL: https://github.com/apache/datafusion/pull/13996#discussion_r1903608854
##
benchmarks/bench.sh:
##
@@ -80,6 +80,9 @@ clickbench_1: ClickBench queries against a single
parquet file
clickbench_partitioned: ClickBench quer
nishikinocurtis commented on issue #13975:
URL: https://github.com/apache/datafusion/issues/13975#issuecomment-2572204916
+1, also encountering cases where parsing and executing queries referring to
rowid is required.
Both logical planning and physical planning (related to `scan()`s)
goldmedal commented on PR #13915:
URL: https://github.com/apache/datafusion/pull/13915#issuecomment-2572217309
> Regarding adding overrides at the `Unparser` level: I like that this
approach would work for all dialects. However, my concern is that there are
cases where configuration is done
cisaacson commented on issue #13994:
URL: https://github.com/apache/datafusion/issues/13994#issuecomment-2572223462
FYI I tried a query with a 6 table join and a single binary operation with
an equals in the predicate in the `WHERE` clause. For 2 of the tables
`supports_pushdown_filters` wa
zhuqi-lucas commented on PR #13996:
URL: https://github.com/apache/datafusion/pull/13996#issuecomment-2572223582
> Thank you, I have tried and there is an issue generating data, everything
else looks good to me.
>
> When I run `./bench.sh data h2o_medum` with python 3.13
>
> ``
zhuqi-lucas commented on PR #13996:
URL: https://github.com/apache/datafusion/pull/13996#issuecomment-2572227494
Also, updated, csv is supported now:
```rust
./benchmarks/bench.sh data h2o_small_csv
***
DataFusion Benchmark Runner and Data Generator
kosiew commented on code in PR #13995:
URL: https://github.com/apache/datafusion/pull/13995#discussion_r1903698138
##
datafusion/core/src/dataframe/mod.rs:
##
@@ -2743,6 +2753,110 @@ mod tests {
Ok(())
}
+// test for https://github.com/apache/datafusion/issue
2010YOUY01 opened a new issue, #14015:
URL: https://github.com/apache/datafusion/issues/14015
### Describe the bug
See reproducer in datafusion-cli (compiled from latest main, commit hash
3f4297f50)
```
DataFusion CLI v44.0.0
> create table t1(v1 int, v2 int);
0 row(s) fet
bfcrampton commented on issue #10073:
URL: https://github.com/apache/datafusion/issues/10073#issuecomment-2572289768
FWIW I'm still seeing the same issue through LanceDB
(https://github.com/lancedb/lance/issues/2119#issuecomment-2136414811).
--
This is an automated message from the Apache
alamb commented on code in PR #14011:
URL: https://github.com/apache/datafusion/pull/14011#discussion_r1903315465
##
datafusion/core/src/datasource/memory.rs:
##
@@ -333,7 +337,11 @@ impl DisplayAs for MemSink {
}
impl MemSink {
+/// Creates a new [`MemSink`].
+///
+
alamb merged PR #1637:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
alamb commented on code in PR #14012:
URL: https://github.com/apache/datafusion/pull/14012#discussion_r1903316252
##
datafusion/expr/src/logical_plan/plan.rs:
##
@@ -1337,17 +1332,12 @@ impl LogicalPlan {
JoinType::RightSemi | JoinType::RightAnti => right.max_ro
alamb commented on PR #14009:
URL: https://github.com/apache/datafusion/pull/14009#issuecomment-2571709524
I also found this gem:
- https://github.com/foresterre/cargo-msrv/pull/882 (thanks @Jefffrey ❤️ )
--
This is an automated message from the Apache Git Service.
To respond to the me
alamb commented on issue #12136:
URL: https://github.com/apache/datafusion/issues/12136#issuecomment-2571710657
> Also hitting this bug, is there any update on a fix ?
I don't know of anyone working explicitly working to make external sorting
better. Some recent work maybe would make
alamb commented on PR #1640:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1640#issuecomment-2571713369
FYI @iffyio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
Dandandan commented on issue #9846:
URL: https://github.com/apache/datafusion/issues/9846#issuecomment-2571713705
> > Is there a rule of thumb for choosing SMJ over HJ?
>
> Is there any plan on re-iterating on the SMJ heuristics ? For example, a
use-case of mine would be: input data i
alamb merged PR #1640:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
avkirilishin opened a new pull request, #14013:
URL: https://github.com/apache/datafusion/pull/14013
## Which issue does this PR close?
Closes #8230.
## What changes are included in this PR?
Added plan execution for `replace_with_order_pres
alamb closed issue #13976: Incorrect `NULL` handling in `BETWEEN` expression
URL: https://github.com/apache/datafusion/issues/13976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
alamb commented on PR #14007:
URL: https://github.com/apache/datafusion/pull/14007#issuecomment-2571706739
Thanks again @getChan 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
alamb merged PR #14007:
URL: https://github.com/apache/datafusion/pull/14007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #14000:
URL: https://github.com/apache/datafusion/pull/14000#issuecomment-2571712236
Thanks again @avkirilishin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alamb closed issue #13979: datafusion-cli displays error prefix twice
URL: https://github.com/apache/datafusion/issues/13979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
alamb merged PR #14000:
URL: https://github.com/apache/datafusion/pull/14000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
milenkovicm commented on issue #9846:
URL: https://github.com/apache/datafusion/issues/9846#issuecomment-2571716342
> > Is there a rule of thumb for choosing SMJ over HJ?
>
>
>
> Is there any plan on re-iterating on the SMJ heuristics ?
>
> For example, a use-case of mi
andygrove commented on PR #1215:
URL:
https://github.com/apache/datafusion-comet/pull/1215#issuecomment-2571722719
Thanks @rluvaton. Could you run `cargo fmt` to fix the CI failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
andygrove commented on code in PR #1217:
URL: https://github.com/apache/datafusion-comet/pull/1217#discussion_r1903324730
##
native/spark-expr/src/static_invoke/mod.rs:
##
@@ -0,0 +1,20 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
codecov-commenter commented on PR #1217:
URL:
https://github.com/apache/datafusion-comet/pull/1217#issuecomment-2571763155
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1217?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
codecov-commenter commented on PR #1218:
URL:
https://github.com/apache/datafusion-comet/pull/1218#issuecomment-2571763307
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1218?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
Omega359 opened a new pull request, #14014:
URL: https://github.com/apache/datafusion/pull/14014
## Which issue does this PR close?
Closes #13969
## Rationale for this change
Add a small bit of docs and links to IDE docs for the newly added dev
container support.
akupchinskiy commented on code in PR #1199:
URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1903222710
##
native/spark-expr/src/rand.rs:
##
@@ -0,0 +1,261 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
tobixdev opened a new issue, #14010:
URL: https://github.com/apache/datafusion/issues/14010
### Describe the bug
Trying to insert into a MemTable with zero partitions causes and index out
of bounds error when executing.
Backtrace:
```
index out of bounds: the len is 0 but
iffyio commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1903247158
##
src/ast/mod.rs:
##
@@ -3341,16 +3341,13 @@ pub enum Statement {
value: Option,
is_eq: bool,
},
-/// ```sql
-/// LOCK T
tobixdev opened a new pull request, #14011:
URL: https://github.com/apache/datafusion/pull/14011
## Which issue does this PR close?
Closes #14010
## Rationale for this change
Implements Option 1. from said issue.
## What changes are included in this PR?
Test
iffyio commented on code in PR #1629:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1629#discussion_r1903251826
##
src/tokenizer.rs:
##
@@ -1855,22 +1855,31 @@ impl<'a> Tokenizer<'a> {
) -> Result, TokenizerError> {
let mut s = String::new();
tobixdev commented on PR #14011:
URL: https://github.com/apache/datafusion/pull/14011#issuecomment-2571592774
@alamb
I hope its OK to mention you for triggering the CI as you've been recently
active and this is my first PR.
Hope this is the expected process :)
--
This is an automat
hansott commented on code in PR #1629:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1629#discussion_r1903252759
##
src/tokenizer.rs:
##
@@ -1855,22 +1855,31 @@ impl<'a> Tokenizer<'a> {
) -> Result, TokenizerError> {
let mut s = String::new();
iffyio commented on code in PR #1630:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1630#discussion_r1903253304
##
src/parser/mod.rs:
##
@@ -2353,14 +2355,30 @@ impl<'a> Parser<'a> {
};
Ok(DateTimeField::Week(week_day))
2010YOUY01 commented on code in PR #13996:
URL: https://github.com/apache/datafusion/pull/13996#discussion_r1903253001
##
benchmarks/bench.sh:
##
@@ -80,6 +80,9 @@ clickbench_1: ClickBench queries against a single
parquet file
clickbench_partitioned: ClickBench queri
Omega359 commented on PR #3:
URL: https://github.com/apache/datafusion-testing/pull/3#issuecomment-2571645385
Note that I can regenerate the .slt files for things like this up until the
point where we are making manual changes (for example, changing the result
values).
--
This is an auto
jonahgao commented on code in PR #14011:
URL: https://github.com/apache/datafusion/pull/14011#discussion_r1903283608
##
datafusion/core/src/datasource/memory.rs:
##
@@ -265,6 +265,10 @@ impl TableProvider for MemTable {
input: Arc,
insert_op: InsertOp,
) -
iffyio merged PR #1629:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
ccciudatu commented on code in PR #13772:
URL: https://github.com/apache/datafusion/pull/13772#discussion_r1903336823
##
datafusion/substrait/src/logical_plan/consumer.rs:
##
@@ -438,6 +439,22 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
user_defined_litera
comphead merged PR #13680:
URL: https://github.com/apache/datafusion/pull/13680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead closed issue #13472: SortMergeJoin: Add RightAnti join support
URL: https://github.com/apache/datafusion/issues/13472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
comphead commented on issue #9846:
URL: https://github.com/apache/datafusion/issues/9846#issuecomment-2571745238
The SMJ still needs some work to be done before we can enable it like
supporting RightSemi/RightAnti. Also the issue was reported with small/empty
batches in
https://github.com/
alamb closed issue #13901: [substrait] customizable producer
URL: https://github.com/apache/datafusion/issues/13901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
alamb commented on issue #11030:
URL: https://github.com/apache/datafusion/issues/11030#issuecomment-2571711736
> Integrate it into the extended CI.
This would be great. We currently have some tests running only on commits to
main:
https://github.com/apache/datafusion/blob/main
alamb commented on PR #13931:
URL: https://github.com/apache/datafusion/pull/13931#issuecomment-2571711867
Thanks again @vbarua and @Blizzara
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb merged PR #13931:
URL: https://github.com/apache/datafusion/pull/13931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
andygrove commented on code in PR #1218:
URL: https://github.com/apache/datafusion-comet/pull/1218#discussion_r1903324984
##
native/spark-expr/src/lib.rs:
##
@@ -62,6 +61,8 @@ mod unbound;
pub use unbound::UnboundColumn;
pub mod utils;
pub use normalize_nan::NormalizeNaNAndZe
rluvaton commented on PR #1215:
URL:
https://github.com/apache/datafusion-comet/pull/1215#issuecomment-2571724445
> Thanks @rluvaton. Could you run `cargo fmt` to fix the CI failures.
Sure, but it's weird, before committed I ran:
1. `cargo build`
2. `cargo fmt`
3. `cargo clip
rluvaton commented on code in PR #1218:
URL: https://github.com/apache/datafusion-comet/pull/1218#discussion_r1903325526
##
native/spark-expr/src/lib.rs:
##
@@ -62,6 +61,8 @@ mod unbound;
pub use unbound::UnboundColumn;
pub mod utils;
pub use normalize_nan::NormalizeNaNAndZer
freshtonic commented on code in PR #1614:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1614#discussion_r1903354362
##
src/ast/mod.rs:
##
@@ -7278,16 +7279,126 @@ impl fmt::Display for SearchModifier {
}
}
+/// A `LOCK TABLE ..` statement. MySQL and Postgr
Omega359 commented on issue #13780:
URL: https://github.com/apache/datafusion/issues/13780#issuecomment-2571776995
The core issue is something related to the cast to the `REAL` type. Changing
the sql to cast to DOUBLE results in the correct results:
```sql
> SELECT - NULLIF ( + 15,
codecov-commenter commented on PR #1223:
URL:
https://github.com/apache/datafusion-comet/pull/1223#issuecomment-2571778749
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1223?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
rluvaton opened a new pull request, #1222:
URL: https://github.com/apache/datafusion-comet/pull/1222
Extracted from:
- #1206
## Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark `E
rluvaton opened a new pull request, #1223:
URL: https://github.com/apache/datafusion-comet/pull/1223
Extracted from:
- #1206
## Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark `E
rluvaton opened a new pull request, #1224:
URL: https://github.com/apache/datafusion-comet/pull/1224
Extracted from:
- #1206
## Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark `E
maruschin opened a new pull request, #14012:
URL: https://github.com/apache/datafusion/pull/14012
## Which issue does this PR close?
Closes #.
## Rationale for this change
I didn't understand the calculation method the first time, I tried to
rewrite it more clear
akupchinskiy commented on code in PR #1199:
URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1903226083
##
native/spark-expr/src/rand.rs:
##
@@ -0,0 +1,261 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
akupchinskiy commented on code in PR #1199:
URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1903227347
##
native/core/src/execution/jni_api.rs:
##
@@ -317,7 +317,7 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_executePlan(
// query
rluvaton opened a new pull request, #1215:
URL: https://github.com/apache/datafusion-comet/pull/1215
Extracted from:
- #1206
## Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark `E
rluvaton commented on PR #1206:
URL:
https://github.com/apache/datafusion-comet/pull/1206#issuecomment-2571571096
> @rluvaton I think that this looks great but it is challenging to really
review the PR with so many changes.
>
> What do you think about breaking this down into some smal
iffyio commented on code in PR #1633:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1633#discussion_r1903254863
##
src/ast/mod.rs:
##
@@ -7698,6 +7698,25 @@ impl fmt::Display for RenameTable {
}
}
+#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Has
hansott commented on PR #1629:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1629#issuecomment-2571607800
@iffyio Addressed your feedback, thanks a lot! Tests passing ✅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
16pierre commented on issue #12136:
URL: https://github.com/apache/datafusion/issues/12136#issuecomment-2571612224
Also hitting this bug, is there any update on a fix ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
alamb commented on issue #9846:
URL: https://github.com/apache/datafusion/issues/9846#issuecomment-2571703716
> This couldn't use SMJ with current heuristics:
In my opinion, we should make more / better knobs for this kind of tuning
(to make it easier to choose what types of joins, et
rluvaton commented on PR #1206:
URL:
https://github.com/apache/datafusion-comet/pull/1206#issuecomment-2571551720
No problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
akupchinskiy commented on PR #1199:
URL:
https://github.com/apache/datafusion-comet/pull/1199#issuecomment-2571552288
> Are the partition related changes necessary for this PR? Otherwise, it
might be better to reduce the scope to just the `rand()` expression.
There is a handful of ex
rluvaton commented on code in PR #1199:
URL: https://github.com/apache/datafusion-comet/pull/1199#discussion_r1903241784
##
native/spark-expr/src/rand.rs:
##
@@ -0,0 +1,272 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreemen
rluvaton opened a new pull request, #1218:
URL: https://github.com/apache/datafusion-comet/pull/1218
Extracted from:
- #1206
## Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark `E
rluvaton opened a new pull request, #1216:
URL: https://github.com/apache/datafusion-comet/pull/1216
Extracted from:
- #1206
## Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark `E
rluvaton opened a new pull request, #1217:
URL: https://github.com/apache/datafusion-comet/pull/1217
Extracted from:
- #1206
## Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark `E
getChan commented on code in PR #14007:
URL: https://github.com/apache/datafusion/pull/14007#discussion_r1903233623
##
datafusion/sqllogictest/test_files/between.slt:
##
@@ -0,0 +1,32 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
thanks. mo
rluvaton opened a new pull request, #1219:
URL: https://github.com/apache/datafusion-comet/pull/1219
Extracted from:
- #1206
## Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark `E
rluvaton opened a new pull request, #1220:
URL: https://github.com/apache/datafusion-comet/pull/1220
Extracted from:
- #1206
## Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark `E
getChan opened a new pull request, #3:
URL: https://github.com/apache/datafusion-testing/pull/3
https://github.com/apache/datafusion/issues/13976 will be fixed by
https://github.com/apache/datafusion/pull/14007
As a result, make changes to ensure that related SQLite tests are not
ski
rluvaton opened a new pull request, #1221:
URL: https://github.com/apache/datafusion-comet/pull/1221
Extracted from:
- #1206
## Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark `E
iffyio commented on code in PR #1628:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1628#discussion_r1903243487
##
src/ast/dml.rs:
##
@@ -547,7 +561,15 @@ impl Display for Insert {
write!(f, "{source}")?;
}
-if self.source.is_none()
87 matches
Mail list logo
