Spaarsh commented on issue #13896:
URL: https://github.com/apache/datafusion/issues/13896#issuecomment-2564828095
I have worked a bit on these lines. I have also added traps that ensure that
cleanup takes place if the user interrupts the downloads intentionally as well.
Trying to apply it t
Chen-Yuan-Lai commented on code in PR #13925:
URL: https://github.com/apache/datafusion/pull/13925#discussion_r1899273406
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -1697,8 +1697,8 @@ upper(str)
**Related functions**:
-- [initcap](#initcap)
- [lower](#lower)
andygrove closed pull request #1180: chore: Add more criterion benchmarks for
shuffle writer
URL: https://github.com/apache/datafusion-comet/pull/1180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on PR #1206:
URL:
https://github.com/apache/datafusion-comet/pull/1206#issuecomment-2564925778
Thanks @rluvaton. This is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
aweltsch commented on issue #11638:
URL: https://github.com/apache/datafusion/issues/11638#issuecomment-2565068742
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
2010YOUY01 commented on PR #13942:
URL: https://github.com/apache/datafusion/pull/13942#issuecomment-2565086574
Perhaps we can use an existing common option to print plans
https://github.com/apache/datafusion/blob/ab69bb04bbcf1b4fd6b528a8433056e9adae67a8/benchmarks/src/util/options.rs#L40
alamb commented on PR #13916:
URL: https://github.com/apache/datafusion/pull/13916#issuecomment-2564721301
Thanks again @getChan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
goldmedal commented on PR #13919:
URL: https://github.com/apache/datafusion/pull/13919#issuecomment-2564721733
I think the PR is just a part of #13671. Modifying the `close` keyword to
`part of` in the PR description is better.
--
This is an automated message from the Apache Git Service.
timsaucer opened a new pull request, #13937:
URL: https://github.com/apache/datafusion/pull/13937
## Which issue does this PR close?
Closes #13827
Closes #13851
## Rationale for this change
During testing with `delta-kernel-rs` and `datafusion-table-providers` it
was
alamb merged PR #13920:
URL: https://github.com/apache/datafusion/pull/13920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
my-vegetable-has-exploded commented on PR #12754:
URL: https://github.com/apache/datafusion/pull/12754#issuecomment-2564720663
> I'm planning on taking a look at this over the next week or so, but it
will take a little time for me to get up to speed on the details of what you're
trying to d
goldmedal merged PR #13918:
URL: https://github.com/apache/datafusion/pull/13918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
alamb merged PR #13916:
URL: https://github.com/apache/datafusion/pull/13916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
goldmedal commented on PR #13918:
URL: https://github.com/apache/datafusion/pull/13918#issuecomment-2564721059
Thanks @Chen-Yuan-Lai and @Omega359 for the reviews.
By the way, I modified the description `close #13671` to `part of #13671`
because I think there are other remaining PR wa
alamb closed issue #13671: doc-gen: Migrate builtin scalar functions from code
based documentation to attribute based
URL: https://github.com/apache/datafusion/issues/13671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
alamb commented on PR #13928:
URL: https://github.com/apache/datafusion/pull/13928#issuecomment-2564722024
Thanks @Chen-Yuan-Lai and @comphead and @Omega359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
alamb merged PR #13928:
URL: https://github.com/apache/datafusion/pull/13928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on code in PR #13928:
URL: https://github.com/apache/datafusion/pull/13928#discussion_r1899129235
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -2907,26 +2906,26 @@ array_has(array, element)
### `array_has_any`
-Returns true if the array contains
alamb merged PR #13922:
URL: https://github.com/apache/datafusion/pull/13922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
iffyio commented on PR #1625:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1625#issuecomment-2564721895
Thanks @alamb!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Chen-Yuan-Lai commented on code in PR #13924:
URL: https://github.com/apache/datafusion/pull/13924#discussion_r1899130452
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -852,10 +852,6 @@ btrim(str[, trim_str])
Alternative Syntax
-```sql
-trim(BOTH trim_str FR
Chen-Yuan-Lai commented on PR #13919:
URL: https://github.com/apache/datafusion/pull/13919#issuecomment-2564724504
Sure! I'll modfy all the other PRs. Thanks @goldmedal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
iffyio merged PR #1624:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
iffyio merged PR #1625:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
iffyio commented on code in PR #1624:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1624#discussion_r1899129845
##
src/parser/mod.rs:
##
@@ -13475,13 +13477,23 @@ impl<'a> Parser<'a> {
}
impl Word {
+#[deprecated(since = "0.54.0", note = "please use `into_
comphead opened a new issue, #13671:
URL: https://github.com/apache/datafusion/issues/13671
### Is your feature request related to a problem or challenge?
It is needed to migrate whenever it is possible builtin UDF documentation
from code based to attribute based.
Function lis
wugeer commented on code in PR #1616:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1616#discussion_r1899131344
##
src/ast/mod.rs:
##
@@ -3401,6 +3401,13 @@ pub enum Statement {
partitioned: Option>,
table_format: Option,
},
+/// ```sql
wugeer commented on code in PR #1616:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1616#discussion_r1899131260
##
src/dialect/mod.rs:
##
@@ -715,6 +715,11 @@ pub trait Dialect: Debug + Any {
true
}
+// Returns true if the dialect supports the
iffyio merged PR #1626:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
alamb commented on PR #13527:
URL: https://github.com/apache/datafusion/pull/13527#issuecomment-2564723081
> Examples check failure is transient I believe.
I restarted the checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alamb commented on code in PR #13527:
URL: https://github.com/apache/datafusion/pull/13527#discussion_r1899131349
##
datafusion-examples/examples/composed_extension_codec.rs:
##
@@ -71,8 +71,10 @@ async fn main() {
// deserialize proto back to execution plan
let runt
alamb commented on code in PR #13936:
URL: https://github.com/apache/datafusion/pull/13936#discussion_r1899135647
##
datafusion/sqllogictest/README.md:
##
@@ -160,7 +161,7 @@ cargo test --test sqllogictests -- information
Test files that start with prefix `pg_compat_` verify co
alamb merged PR #13923:
URL: https://github.com/apache/datafusion/pull/13923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #1626:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1626#issuecomment-2564746313
Thanks @iffyio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alamb opened a new issue, #13938:
URL: https://github.com/apache/datafusion/issues/13938
### Is your feature request related to a problem or challenge?
_No response_
### Describe the solution you'd like
_No response_
### Describe alternatives you've considered
alamb commented on code in PR #13910:
URL: https://github.com/apache/datafusion/pull/13910#discussion_r1899159234
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -566,8 +566,87 @@ impl HashJoinExec {
boundedness_from_children([left, right]),
))
alamb commented on code in PR #13939:
URL: https://github.com/apache/datafusion/pull/13939#discussion_r1899157149
##
datafusion-examples/examples/dataframe.rs:
##
@@ -28,16 +28,24 @@ use std::io::Write;
use std::sync::Arc;
use tempfile::tempdir;
-/// This example demonstrate
alamb commented on code in PR #13910:
URL: https://github.com/apache/datafusion/pull/13910#discussion_r1899158392
##
datafusion/physical-plan/src/joins/hash_join.rs:
##
@@ -566,8 +566,87 @@ impl HashJoinExec {
boundedness_from_children([left, right]),
))
alamb opened a new pull request, #13940:
URL: https://github.com/apache/datafusion/pull/13940
## Which issue does this PR close?
Closes #.
## Rationale for this change
Test out the question of "why bother to pass this parameter" from
@berkaysynnada on
https://g
zhuqi-lucas commented on PR #13933:
URL: https://github.com/apache/datafusion/pull/13933#issuecomment-2564654544
This PR seems also can resolve the issue:
https://github.com/apache/datafusion/issues/4177
--
This is an automated message from the Apache Git Service.
To respond to the mess
alamb commented on issue #13938:
URL: https://github.com/apache/datafusion/issues/13938#issuecomment-2564765599
I would like to do this one myself and then I will file tickets for the
other similar examples that I think others could work on in parallel
--
This is an automated message from
alamb commented on issue #13938:
URL: https://github.com/apache/datafusion/issues/13938#issuecomment-2564766951
After studying regexp.rs I think the content actually should go into the
docs for the various regexp functions rather than the examples. 🤔
--
This is an automated message from
alamb closed issue #13938: Consolidate Examples: regexp.rs into dataframe.rs
and sql_query.rs
URL: https://github.com/apache/datafusion/issues/13938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alamb opened a new pull request, #13939:
URL: https://github.com/apache/datafusion/pull/13939
## Which issue does this PR close?
- Part of https://github.com/apache/datafusion/issues/11172
## Rationale for this change
1. Make it easier to find relevant examples
2. Make
Blizzara commented on code in PR #13772:
URL: https://github.com/apache/datafusion/pull/13772#discussion_r1899123986
##
datafusion/substrait/src/logical_plan/consumer.rs:
##
@@ -438,6 +439,22 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
user_defined_literal
Blizzara commented on code in PR #13772:
URL: https://github.com/apache/datafusion/pull/13772#discussion_r1899123986
##
datafusion/substrait/src/logical_plan/consumer.rs:
##
@@ -438,6 +439,22 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
user_defined_literal
zhuqi-lucas commented on PR #13933:
URL: https://github.com/apache/datafusion/pull/13933#issuecomment-2564681235
Hi @ozankabak , thank you for review, we can propagate source ordering with:
1. Create external table with order
2. Create a parquet read with list options to setting the ord
zhuqi-lucas commented on PR #13933:
URL: https://github.com/apache/datafusion/pull/13933#issuecomment-2564651319
Hi @alamb @Dandandan , i submitted the first version PR for the
automatically detect parquet file order and using the info to optimize for the
plan. It's a very basic PR, we ca
ozankabak commented on PR #13933:
URL: https://github.com/apache/datafusion/pull/13933#issuecomment-2564669696
I haven't reviewed this PR carefully yet, but we already have mechanisms to
propagate source ordering. Why do we need to add this information to
`Statistics`?
--
This is an auto
Omega359 commented on code in PR #13936:
URL: https://github.com/apache/datafusion/pull/13936#discussion_r1899165327
##
datafusion/sqllogictest/src/engines/datafusion_engine/normalize.rs:
##
@@ -239,6 +239,10 @@ pub fn cell_to_string(col: &ArrayRef, row: usize) ->
Result {
Omega359 commented on code in PR #13936:
URL: https://github.com/apache/datafusion/pull/13936#discussion_r1899165410
##
datafusion/sqllogictest/bin/sqllogictests.rs:
##
@@ -16,57 +16,129 @@
// under the License.
use clap::Parser;
+use datafusion_common::instant::Instant;
us
Omega359 commented on PR #13936:
URL: https://github.com/apache/datafusion/pull/13936#issuecomment-2564785325
Git submodules - for me this worked (as documented in the description above):
`git submodule update --init --remote --recursive`
Sub modules with branches should be easier t
comphead commented on code in PR #13924:
URL: https://github.com/apache/datafusion/pull/13924#discussion_r1899182207
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -852,10 +852,6 @@ btrim(str[, trim_str])
Alternative Syntax
-```sql
-trim(BOTH trim_str FROM st
comphead commented on PR #13921:
URL: https://github.com/apache/datafusion/pull/13921#issuecomment-2564819000
Looks like the doc macros doesn't work for this PR for some functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
comphead commented on code in PR #13924:
URL: https://github.com/apache/datafusion/pull/13924#discussion_r1899182342
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -852,10 +852,6 @@ btrim(str[, trim_str])
Alternative Syntax
-```sql
-trim(BOTH trim_str FROM st
comphead commented on code in PR #13925:
URL: https://github.com/apache/datafusion/pull/13925#discussion_r1899182540
##
docs/source/user-guide/sql/scalar_functions.md:
##
@@ -1697,8 +1697,8 @@ upper(str)
**Related functions**:
-- [initcap](#initcap)
- [lower](#lower)
Revi
comphead commented on code in PR #13680:
URL: https://github.com/apache/datafusion/pull/13680#discussion_r1899184661
##
datafusion/sqllogictest/test_files/sort_merge_join.slt:
##
@@ -647,6 +647,54 @@ NULL NULL 7 9
NULL NULL 8 10
NULL NULL 9 11
+query II
+select * from (
+wit
comphead commented on code in PR #13680:
URL: https://github.com/apache/datafusion/pull/13680#discussion_r1899184898
##
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##
@@ -1920,6 +1939,10 @@ impl SortMergeJoinStream {
let output_column_indices =
(0..left_
comphead commented on code in PR #13680:
URL: https://github.com/apache/datafusion/pull/13680#discussion_r1899184783
##
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##
@@ -2910,6 +2984,310 @@ mod tests {
Ok(())
}
+#[tokio::test]
+async fn join_r
Omega359 commented on code in PR #13527:
URL: https://github.com/apache/datafusion/pull/13527#discussion_r1899197257
##
datafusion/physical-expr/src/scalar_function.rs:
##
@@ -243,6 +292,7 @@ pub fn create_physical_expr(
Arc::new(fun.clone()),
input_phy
andygrove commented on PR #1199:
URL:
https://github.com/apache/datafusion-comet/pull/1199#issuecomment-2564989612
Thanks @akupchinskiy. I plan on reviewing this after the holidays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
Omega359 commented on PR #13936:
URL: https://github.com/apache/datafusion/pull/13936#issuecomment-2564787721
> When I ran this branch with
>
> External error: task 27341 panicked with message "called
`Result::unwrap()` on an `Err` value: ParseError { kind:
UnexpectedToken("label-1")
comphead commented on PR #13680:
URL: https://github.com/apache/datafusion/pull/13680#issuecomment-2564818136
Thanks @Omega359 and @irenjj somehow I missed that, I'll check it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
comphead merged PR #13929:
URL: https://github.com/apache/datafusion/pull/13929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead merged PR #13930:
URL: https://github.com/apache/datafusion/pull/13930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead commented on PR #13921:
URL: https://github.com/apache/datafusion/pull/13921#issuecomment-2564818864
Something wrong here, looks like doc macros is not working in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Chen-Yuan-Lai closed pull request #13878: doc-gen: migrate builtin scalar
functions documentation to attribute based
URL: https://github.com/apache/datafusion/pull/13878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
zhuqi-lucas commented on issue #13941:
URL: https://github.com/apache/datafusion/issues/13941#issuecomment-2564946444
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zhuqi-lucas opened a new issue, #13941:
URL: https://github.com/apache/datafusion/issues/13941
### Is your feature request related to a problem or challenge?
When running dfbench, i want to know the explain result and compare with
other engines or to do the optimization.
### De
zhuqi-lucas opened a new pull request, #13942:
URL: https://github.com/apache/datafusion/pull/13942
## Which issue does this PR close?
Closes [#13941 ](https://github.com/apache/datafusion/issues/13941)
## Rationale for this change
## What changes are included in this
zhuqi-lucas commented on PR #13942:
URL: https://github.com/apache/datafusion/pull/13942#issuecomment-2564951633
cc @alamb It's a small change for explain support for dfbench, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Omega359 commented on PR #13936:
URL: https://github.com/apache/datafusion/pull/13936#issuecomment-2564848261
- submodule - readme updated with correct git submodule command to run.
- sqlite test suite linked in docs now
- Force version 0.24.0 of sqllogictest dependency until issue upst
comphead merged PR #13927:
URL: https://github.com/apache/datafusion/pull/13927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead commented on PR #13878:
URL: https://github.com/apache/datafusion/pull/13878#issuecomment-2564821624
should we close it @Chen-Yuan-Lai ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
comphead commented on code in PR #13939:
URL: https://github.com/apache/datafusion/pull/13939#discussion_r1899183249
##
datafusion-examples/examples/dataframe.rs:
##
@@ -206,3 +215,38 @@ async fn write_out(ctx: &SessionContext) ->
std::result::Result<(), DataFusionEr
Ok(
rluvaton opened a new pull request, #1206:
URL: https://github.com/apache/datafusion-comet/pull/1206
## Rationale for this change
Making it easier to find functions and add stuff at the right location
the sub folder name are named after Spark `ExpressionDescription` `group`
zhuqi-lucas commented on PR #13942:
URL: https://github.com/apache/datafusion/pull/13942#issuecomment-2565131365
Thank you @2010YOUY01 for review and good suggestion! Addressed in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
77 matches
Mail list logo
