Re: [PR] use 'lit' as the field name for literal values [datafusion]

2025-06-23 Thread via GitHub
adriangb merged PR #16498: URL: https://github.com/apache/datafusion/pull/16498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dataf

Re: [PR] use 'lit' as the field name for literal values [datafusion]

2025-06-22 Thread via GitHub
alamb commented on code in PR #16498: URL: https://github.com/apache/datafusion/pull/16498#discussion_r2160359663 ## datafusion/physical-expr/src/expressions/literal.rs: ## @@ -66,8 +66,7 @@ impl Literal { value: ScalarValue, metadata: Option, ) -> Self {

Re: [PR] use 'lit' as the field name for literal values [datafusion]

2025-06-22 Thread via GitHub
adriangb commented on PR #16498: URL: https://github.com/apache/datafusion/pull/16498#issuecomment-2994218318 Thanks folks. One more thought: I wonder if this improves performance by some small fraction given that I could see `lit(..)` being called in hot loops in some place... Anywa

Re: [PR] use 'lit' as the field name for literal values [datafusion]

2025-06-22 Thread via GitHub
alamb commented on PR #16498: URL: https://github.com/apache/datafusion/pull/16498#issuecomment-2994123402 FYI @timsaucer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T