Re: [PR] remove unused methods in SortExec [datafusion]

2025-06-19 Thread via GitHub
adriangb commented on PR #16457: URL: https://github.com/apache/datafusion/pull/16457#issuecomment-2988806515 Thanks for the review @comphead ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] remove unused methods in SortExec [datafusion]

2025-06-19 Thread via GitHub
adriangb merged PR #16457: URL: https://github.com/apache/datafusion/pull/16457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dataf

Re: [PR] remove unused methods in SortExec [datafusion]

2025-06-19 Thread via GitHub
comphead commented on PR #16457: URL: https://github.com/apache/datafusion/pull/16457#issuecomment-2988800023 > We just added them in #15770 2 days ago. I'm 99% certain no downstream projects are using them. I feel it would be less painful to just rip them out right now rather than having t

Re: [PR] remove unused methods in SortExec [datafusion]

2025-06-19 Thread via GitHub
adriangb commented on PR #16457: URL: https://github.com/apache/datafusion/pull/16457#issuecomment-2988748949 We just added them in #15770 2 days ago. I'm 99% certain no downstream projects are using them. I feel it would be less painful to just rip them out right now rather than having the