timsaucer commented on PR #1015:
URL:
https://github.com/apache/datafusion-python/pull/1015#issuecomment-2970821413
Original problem was resolved by
https://github.com/apache/datafusion-python/pull/1036 which I believe used part
of this work. Thank you very much for the contribution!
--
timsaucer closed pull request #1015: refactor: collect dataframe as stream in
`__repr__`
URL: https://github.com/apache/datafusion-python/pull/1015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
konjac commented on PR #1015:
URL:
https://github.com/apache/datafusion-python/pull/1015#issuecomment-2676912860
> This looks good. It took me a while to parse through the logic of the
`get_batches`. I think it's worth adding some documentation within the file to
explain why we are doing t
konjac commented on code in PR #1015:
URL:
https://github.com/apache/datafusion-python/pull/1015#discussion_r1959666298
##
src/dataframe.rs:
##
@@ -90,8 +91,16 @@ impl PyDataFrame {
}
fn __repr__(&self, py: Python) -> PyDataFusionResult {
-let df = self.df.a
konjac commented on code in PR #1015:
URL:
https://github.com/apache/datafusion-python/pull/1015#discussion_r1959678559
##
src/dataframe.rs:
##
@@ -90,8 +91,16 @@ impl PyDataFrame {
}
fn __repr__(&self, py: Python) -> PyDataFusionResult {
-let df = self.df.a
konjac commented on code in PR #1015:
URL:
https://github.com/apache/datafusion-python/pull/1015#discussion_r1959666298
##
src/dataframe.rs:
##
@@ -90,8 +91,16 @@ impl PyDataFrame {
}
fn __repr__(&self, py: Python) -> PyDataFusionResult {
-let df = self.df.a
timsaucer commented on code in PR #1015:
URL:
https://github.com/apache/datafusion-python/pull/1015#discussion_r1957173874
##
src/dataframe.rs:
##
@@ -90,8 +91,16 @@ impl PyDataFrame {
}
fn __repr__(&self, py: Python) -> PyDataFusionResult {
-let df = self.d
konjac commented on PR #1015:
URL:
https://github.com/apache/datafusion-python/pull/1015#issuecomment-2644492439
Hi @timsaucer , could you help to trigger CI and also review the proposed
change? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the mes
