alamb merged PR #15405:
URL: https://github.com/apache/datafusion/pull/15405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #15405:
URL: https://github.com/apache/datafusion/pull/15405#issuecomment-2755747018
Thank you @2010YOUY01 and @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
2010YOUY01 commented on PR #15405:
URL: https://github.com/apache/datafusion/pull/15405#issuecomment-2753553121
Thank you @alamb and @comphead for the review.
I pushed another commit to resolve the conflict caused by a related refactor
(split `SpillManager` to a separate file)
--
This
2010YOUY01 commented on PR #15405:
URL: https://github.com/apache/datafusion/pull/15405#issuecomment-2753544418
> Thanks @2010YOUY01 lgtm I'm also thinking if we should give a spill
manager the read spilled files functions?
Yes there is already a basic one:
https://github.com/apac
alamb commented on code in PR #15405:
URL: https://github.com/apache/datafusion/pull/15405#discussion_r2012559291
##
datafusion/physical-plan/src/aggregates/row_hash.rs:
##
@@ -981,28 +978,30 @@ impl GroupedHashAggregateStream {
Ok(())
}
-/// Emit all rows, s
