2010YOUY01 merged PR #14566:
URL: https://github.com/apache/datafusion/pull/14566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
ctsk commented on code in PR #14566:
URL: https://github.com/apache/datafusion/pull/14566#discussion_r1957165631
##
datafusion/physical-plan/src/aggregates/order/partial.rs:
##
@@ -103,47 +102,46 @@ enum State {
Complete,
}
+impl State {
+fn size(&self) -> usize {
+
zhuqi-lucas commented on code in PR #14566:
URL: https://github.com/apache/datafusion/pull/14566#discussion_r1957146770
##
datafusion/physical-plan/src/aggregates/order/partial.rs:
##
@@ -207,46 +222,151 @@ impl GroupOrderingPartial {
let max_group_index = total_num_g
ctsk commented on code in PR #14566:
URL: https://github.com/apache/datafusion/pull/14566#discussion_r1957098299
##
datafusion/physical-plan/src/aggregates/order/partial.rs:
##
@@ -103,47 +102,46 @@ enum State {
Complete,
}
+impl State {
+fn size(&self) -> usize {
+
alamb commented on code in PR #14566:
URL: https://github.com/apache/datafusion/pull/14566#discussion_r1957095189
##
datafusion/physical-plan/src/aggregates/order/partial.rs:
##
@@ -103,47 +102,46 @@ enum State {
Complete,
}
+impl State {
+fn size(&self) -> usize {
+
2010YOUY01 commented on code in PR #14566:
URL: https://github.com/apache/datafusion/pull/14566#discussion_r1955903950
##
datafusion/physical-plan/src/aggregates/order/partial.rs:
##
@@ -103,47 +102,46 @@ enum State {
Complete,
}
+impl State {
+fn size(&self) -> usiz
lewiszlw commented on code in PR #14566:
URL: https://github.com/apache/datafusion/pull/14566#discussion_r1955511641
##
datafusion/physical-plan/src/aggregates/order/partial.rs:
##
@@ -103,47 +102,46 @@ enum State {
Complete,
}
+impl State {
+fn size(&self) -> usize
ctsk commented on PR #14566:
URL: https://github.com/apache/datafusion/pull/14566#issuecomment-2656916325
Thank you for taking the time to review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
2010YOUY01 commented on PR #14566:
URL: https://github.com/apache/datafusion/pull/14566#issuecomment-2655677717
Thank you, this looks good to me. Let's get the CI fixed.
https://github.com/apache/datafusion/blob/main/datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs
should have good
