Re: [PR] move information_schema to datafusion-catalog [datafusion]

2025-01-30 Thread via GitHub
alamb commented on PR #14364: URL: https://github.com/apache/datafusion/pull/14364#issuecomment-2625190971 Thanks again @logan-keede -- I will try and write up something later this week or over the weekend -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] move information_schema to datafusion-catalog [datafusion]

2025-01-30 Thread via GitHub
alamb merged PR #14364: URL: https://github.com/apache/datafusion/pull/14364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] move information_schema to datafusion-catalog [datafusion]

2025-01-29 Thread via GitHub
logan-keede commented on PR #14364: URL: https://github.com/apache/datafusion/pull/14364#issuecomment-2622850087 > If you are feeling like some more refactoring projects, any chance you are interested in working to split out the data sources (aka make `datafusion-datasource-parquet`, `dataf

Re: [PR] move information_schema to datafusion-catalog [datafusion]

2025-01-29 Thread via GitHub
logan-keede commented on code in PR #14364: URL: https://github.com/apache/datafusion/pull/14364#discussion_r1934571539 ## datafusion/substrait/Cargo.toml: ## @@ -46,6 +46,7 @@ url = { workspace = true } [dev-dependencies] datafusion = { workspace = true, features = ["nested

Re: [PR] move information_schema to datafusion-catalog [datafusion]

2025-01-29 Thread via GitHub
logan-keede commented on code in PR #14364: URL: https://github.com/apache/datafusion/pull/14364#discussion_r1934568525 ## datafusion/catalog/src/lib.rs: ## @@ -18,23 +18,264 @@ //! Interfaces and default implementations of catalogs and schemas. //! //! Implementations +//! *

Re: [PR] move information_schema to datafusion-catalog [datafusion]

2025-01-29 Thread via GitHub
alamb commented on code in PR #14364: URL: https://github.com/apache/datafusion/pull/14364#discussion_r1934520683 ## datafusion/substrait/Cargo.toml: ## @@ -46,6 +46,7 @@ url = { workspace = true } [dev-dependencies] datafusion = { workspace = true, features = ["nested_expre

Re: [PR] move information_schema to datafusion-catalog [datafusion]

2025-01-29 Thread via GitHub
alamb commented on PR #14364: URL: https://github.com/apache/datafusion/pull/14364#issuecomment-2622752446 I am checking this one out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] move information_schema to datafusion-catalog [datafusion]

2025-01-29 Thread via GitHub
logan-keede commented on PR #14364: URL: https://github.com/apache/datafusion/pull/14364#issuecomment-2622655265 cc @comphead @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific