lovasoa commented on PR #1847:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1847#issuecomment-2876743720
Great, thank you @alamb !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb merged PR #1847:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
alamb commented on PR #1847:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1847#issuecomment-2876519529
I think this is pretty non controversial so let's merge it. @iffyio let us
know if you would like any changes
--
This is an automated message from the Apache Git Service
lovasoa commented on PR #1847:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1847#issuecomment-2875568296
I'd love if we could merge this one and then I'll follow up with improvements
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
lovasoa commented on code in PR #1847:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1847#discussion_r2085360498
##
src/display_utils.rs:
##
@@ -0,0 +1,133 @@
+//! Utilities for formatting SQL AST nodes with pretty printing support.
+//!
+//! The module provides f
alamb commented on code in PR #1847:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1847#discussion_r2085270580
##
src/ast/mod.rs:
##
@@ -628,7 +634,12 @@ pub struct CaseWhen {
impl fmt::Display for CaseWhen {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::R
fivemtebex commented on PR #1847:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1847#issuecomment-2868151947
Impressive project structure! The architecture really demonstrates solid
design principles.
--
This is an automated message from the Apache Git Service.
To respond t
