Re: [PR] fix: support read Struct by user schema [datafusion-comet]

2025-06-11 Thread via GitHub
andygrove merged PR #1860: URL: https://github.com/apache/datafusion-comet/pull/1860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] fix: support read Struct by user schema [datafusion-comet]

2025-06-11 Thread via GitHub
andygrove commented on PR #1860: URL: https://github.com/apache/datafusion-comet/pull/1860#issuecomment-2964357089 miri failure due to https://github.com/apache/datafusion-comet/issues/1871 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] fix: support read Struct by user schema [datafusion-comet]

2025-06-10 Thread via GitHub
comphead commented on code in PR #1860: URL: https://github.com/apache/datafusion-comet/pull/1860#discussion_r2139136916 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -2728,4 +2728,35 @@ class CometExpressionSuite extends CometTestBase with Adaptive

Re: [PR] fix: support read Struct by user schema [datafusion-comet]

2025-06-10 Thread via GitHub
andygrove commented on code in PR #1860: URL: https://github.com/apache/datafusion-comet/pull/1860#discussion_r2138035209 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -2728,4 +2728,35 @@ class CometExpressionSuite extends CometTestBase with Adaptiv

Re: [PR] fix: support read Struct by user schema [datafusion-comet]

2025-06-06 Thread via GitHub
codecov-commenter commented on PR #1860: URL: https://github.com/apache/datafusion-comet/pull/1860#issuecomment-2951225627 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1860?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] fix: support read Struct by user schema [datafusion-comet]

2025-06-06 Thread via GitHub
comphead commented on code in PR #1860: URL: https://github.com/apache/datafusion-comet/pull/1860#discussion_r2133038151 ## spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala: ## @@ -862,6 +862,7 @@ abstract class CometTestBase testName: String = "test",

Re: [PR] fix: support read Struct by user schema [datafusion-comet]

2025-06-06 Thread via GitHub
comphead commented on code in PR #1860: URL: https://github.com/apache/datafusion-comet/pull/1860#discussion_r2133038738 ## native/core/src/parquet/parquet_support.rs: ## @@ -239,14 +242,24 @@ fn cast_struct_to_struct( parquet_options,

Re: [PR] fix: support read Struct by user schema [datafusion-comet]

2025-06-06 Thread via GitHub
comphead commented on code in PR #1860: URL: https://github.com/apache/datafusion-comet/pull/1860#discussion_r2133040038 ## native/core/src/execution/planner.rs: ## @@ -3331,4 +3347,146 @@ mod tests { Ok(()) } + +#[tokio::test] +async fn test_nested_types