Re: [PR] fix: serialize listing table without partition column [datafusion]

2025-04-17 Thread via GitHub
alamb commented on PR #15737: URL: https://github.com/apache/datafusion/pull/15737#issuecomment-2813800026 Thanks again @chenkovsky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] fix: serialize listing table without partition column [datafusion]

2025-04-17 Thread via GitHub
alamb merged PR #15737: URL: https://github.com/apache/datafusion/pull/15737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] fix: serialize listing table without partition column [datafusion]

2025-04-17 Thread via GitHub
alamb commented on code in PR #15737: URL: https://github.com/apache/datafusion/pull/15737#discussion_r2049073244 ## datafusion/proto/src/logical_plan/mod.rs: ## @@ -458,23 +458,24 @@ impl AsLogicalPlan for LogicalPlanNode { .map(ListingTableUrl::parse)

Re: [PR] fix: serialize listing table without partition column [datafusion]

2025-04-17 Thread via GitHub
milenkovicm commented on PR #15737: URL: https://github.com/apache/datafusion/pull/15737#issuecomment-2812298253 Thanks @chenkovsky i think changes make sense, very clean implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to