alamb commented on code in PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#discussion_r2030129209
##
datafusion/sql/src/select.rs:
##
@@ -891,29 +892,42 @@ fn match_window_definitions(
named_windows: &[NamedWindowDefinition],
) -> Result<()> {
for proj
jonahgao commented on code in PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#discussion_r2029886625
##
datafusion/sql/src/select.rs:
##
@@ -891,29 +892,42 @@ fn match_window_definitions(
named_windows: &[NamedWindowDefinition],
) -> Result<()> {
for p
jonahgao merged PR #15033:
URL: https://github.com/apache/datafusion/pull/15033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
alamb commented on PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#issuecomment-2779559031
@jonahgao would you possibly have time to help review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chenkovsky commented on PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#issuecomment-2779066166
could anyone help to review thir pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
2010YOUY01 commented on code in PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#discussion_r1996542785
##
datafusion/sql/src/select.rs:
##
@@ -887,29 +888,42 @@ fn match_window_definitions(
named_windows: &[NamedWindowDefinition],
) -> Result<()> {
for
alamb commented on code in PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#discussion_r1996239262
##
datafusion/core/tests/sql/sql_api.rs:
##
@@ -19,6 +19,23 @@ use datafusion::prelude::*;
use tempfile::TempDir;
+#[tokio::test]
+async fn test_window_function
chenkovsky commented on PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#issuecomment-2716479320
@alamb could you please review it agian. I have found the solution that
doesn't need to touch stack size.
--
This is an automated message from the Apache Git Service.
To respond
chenkovsky commented on PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#issuecomment-2708239635
i'm working on rewriting visit logic. but I found this pr
https://github.com/apache/datafusion-sqlparser-rs/pull/1522/ . does it mean
that this pr doesn't take effect on the test
chenkovsky commented on PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#issuecomment-2708243765
by the way, If I change tokio to single thread, there's also no stack
overflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
chenkovsky commented on PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#issuecomment-2702448317
> > @alamb I think I have to add a BFS visitor in sqlparse crate, how do you
feel about it?
>
> i think that would mean it will take at least another month to fix this
issu
chenkovsky commented on PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#issuecomment-2702473080
> > @alamb I think I have to add a BFS visitor in sqlparse crate, how do you
feel about it?
>
>
>
> i think that would mean it will take at least another month to fi
alamb commented on PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#issuecomment-2702422268
> @alamb I think I have to add a BFS visitor in sqlparse crate, how do you
feel about it?
i think that would mean it will take at least another month to fix this
issue - as we w
chenkovsky commented on PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#issuecomment-2702420018
@alamb I think I have to add a BFS visitor in sqlparse crate, how do you
feel about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
chenkovsky commented on PR #15033:
URL: https://github.com/apache/datafusion/pull/15033#issuecomment-2702349518
sqllogictest complains stackoverflow. because I added a recursive visitor.
but if I add stacksize, it works. so I think it's not real stackoverflow. Let
me check how to refine it.
15 matches
Mail list logo