Re: [PR] fix: isCometEnabled name conflict [datafusion-comet]

2025-04-05 Thread via GitHub
kazuyukitanimura commented on PR #1569: URL: https://github.com/apache/datafusion-comet/pull/1569#issuecomment-2752028058 > TBH, I don't see how this conflict is occurring. `CometSparkSessionExtensionSuite` has no reference to `SQLTestUtilsBase` CometSparkSessionExtensionSuite -> Com

Re: [PR] fix: isCometEnabled name conflict [datafusion-comet]

2025-04-04 Thread via GitHub
comphead commented on code in PR #1569: URL: https://github.com/apache/datafusion-comet/pull/1569#discussion_r2013066556 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -1174,7 +1174,7 @@ object CometSparkSessionExtensions extends Logging { /

Re: [PR] fix: isCometEnabled name conflict [datafusion-comet]

2025-03-25 Thread via GitHub
kazuyukitanimura commented on PR #1569: URL: https://github.com/apache/datafusion-comet/pull/1569#issuecomment-2752978026 Thanks merged @parthchandra @comphead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] fix: isCometEnabled name conflict [datafusion-comet]

2025-03-25 Thread via GitHub
kazuyukitanimura merged PR #1569: URL: https://github.com/apache/datafusion-comet/pull/1569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

Re: [PR] fix: isCometEnabled name conflict [datafusion-comet]

2025-03-25 Thread via GitHub
parthchandra commented on code in PR #1569: URL: https://github.com/apache/datafusion-comet/pull/1569#discussion_r2013108125 ## spark/src/test/scala/org/apache/comet/CometSparkSessionExtensionsSuite.scala: ## @@ -27,24 +27,24 @@ class CometSparkSessionExtensionsSuite extends Co

Re: [PR] fix: isCometEnabled name conflict [datafusion-comet]

2025-03-25 Thread via GitHub
comphead commented on code in PR #1569: URL: https://github.com/apache/datafusion-comet/pull/1569#discussion_r2013066694 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -976,7 +976,7 @@ class CometSparkSessionExtensions } // We s

Re: [PR] fix: isCometEnabled name conflict [datafusion-comet]

2025-03-25 Thread via GitHub
kazuyukitanimura commented on code in PR #1569: URL: https://github.com/apache/datafusion-comet/pull/1569#discussion_r2012813465 ## spark/src/test/scala/org/apache/comet/CometSparkSessionExtensionsSuite.scala: ## @@ -27,24 +27,24 @@ class CometSparkSessionExtensionsSuite extends

Re: [PR] fix: isCometEnabled name conflict [datafusion-comet]

2025-03-25 Thread via GitHub
comphead commented on code in PR #1569: URL: https://github.com/apache/datafusion-comet/pull/1569#discussion_r2012602405 ## spark/src/test/scala/org/apache/comet/CometSparkSessionExtensionsSuite.scala: ## @@ -27,24 +27,24 @@ class CometSparkSessionExtensionsSuite extends CometT

Re: [PR] fix: isCometEnabled name conflict [datafusion-comet]

2025-03-25 Thread via GitHub
parthchandra commented on code in PR #1569: URL: https://github.com/apache/datafusion-comet/pull/1569#discussion_r2012564968 ## spark/src/test/scala/org/apache/comet/CometSparkSessionExtensionsSuite.scala: ## @@ -27,24 +27,24 @@ class CometSparkSessionExtensionsSuite extends Co

Re: [PR] fix: isCometEnabled name conflict [datafusion-comet]

2025-03-24 Thread via GitHub
codecov-commenter commented on PR #1569: URL: https://github.com/apache/datafusion-comet/pull/1569#issuecomment-2749898991 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1569?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca