kazuyukitanimura commented on PR #1385:
URL:
https://github.com/apache/datafusion-comet/pull/1385#issuecomment-2715392485
Merged thanks @himadripal @andygrove @parthchandra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kazuyukitanimura merged PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1987983268
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1210,27 +1213,36 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlan
andygrove commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1987807688
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1210,27 +1213,36 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanH
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1987983268
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1210,27 +1213,36 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlan
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1987886072
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1210,27 +1213,36 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlan
kazuyukitanimura commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1987953695
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1210,27 +1213,36 @@ class CometCastSuite extends CometTestBase with
AdaptiveSpa
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1987983268
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1210,27 +1213,36 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlan
himadripal commented on PR #1385:
URL:
https://github.com/apache/datafusion-comet/pull/1385#issuecomment-2708663771
> I left a comment about a missing assertion
@andygrove I did not see this comment. Although I reverted previous changes
related to spark3.3 assertion and added a chec
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1986214497
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1126,27 +1129,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlan
andygrove commented on PR #1385:
URL:
https://github.com/apache/datafusion-comet/pull/1385#issuecomment-2707578544
Apologies for the late review @himadripal. I checked out the branch locally
and ran some additional manual testing and could not find any issues. I left a
comment about a miss
andygrove commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1985765346
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1126,27 +1129,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanH
andygrove commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1985746876
##
spark/src/main/scala/org/apache/comet/GenerateDocs.scala:
##
@@ -69,7 +69,8 @@ object GenerateDocs {
w.write("|-|-|-|\n".getBytes)
for (
kazuyukitanimura commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1968689241
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1126,27 +1129,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSpa
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1968655592
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1126,27 +1129,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlan
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1968654009
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1126,27 +1129,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlan
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1968652251
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1126,27 +1129,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlan
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1968652251
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1126,27 +1129,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlan
kazuyukitanimura commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1968649099
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1126,27 +1129,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSpa
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1966132652
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1126,27 +1129,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlan
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1966132652
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1126,27 +1129,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlan
himadripal commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1966133439
##
spark/src/main/scala/org/apache/comet/GenerateDocs.scala:
##
@@ -69,7 +69,8 @@ object GenerateDocs {
w.write("|-|-|-|\n".getBytes)
for
kazuyukitanimura commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1966118342
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -1126,27 +1129,33 @@ class CometCastSuite extends CometTestBase with
AdaptiveSpa
kazuyukitanimura commented on code in PR #1385:
URL: https://github.com/apache/datafusion-comet/pull/1385#discussion_r1956612664
##
docs/source/user-guide/compatibility.md:
##
@@ -73,76 +73,77 @@ Spark.
The following cast operations are generally compatible with Spark except fo
24 matches
Mail list logo
