huaxingao commented on PR #1723:
URL:
https://github.com/apache/datafusion-comet/pull/1723#issuecomment-2887151838
We actually don't need this PR any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
huaxingao closed pull request #1723: fix: Support Schema Evolution in iceberg
URL: https://github.com/apache/datafusion-comet/pull/1723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
comphead commented on PR #1723:
URL:
https://github.com/apache/datafusion-comet/pull/1723#issuecomment-2887069661
are we good to merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
huaxingao commented on PR #1723:
URL:
https://github.com/apache/datafusion-comet/pull/1723#issuecomment-2876826410
> The config CometConf.COMET_SCHEMA_EVOLUTION_ENABLED is valid for Parquet
files as well so removing it is not correct imo.
I have added back `COMET_SCHEMA_EVOLUTION_ENA
huaxingao closed pull request #1723: fix: Support Schema Evolution in iceberg
URL: https://github.com/apache/datafusion-comet/pull/1723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
huaxingao closed pull request #1723: fix: Support Schema Evolution in iceberg
URL: https://github.com/apache/datafusion-comet/pull/1723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
parthchandra commented on PR #1723:
URL:
https://github.com/apache/datafusion-comet/pull/1723#issuecomment-2867573764
One set of Spark Sql test failures in native_iceberg_compat is exactly
because this schema evolution/type promotion check is not being performed
correctly (or not being per
parthchandra commented on PR #1723:
URL:
https://github.com/apache/datafusion-comet/pull/1723#issuecomment-2867552108
The config `CometConf.COMET_SCHEMA_EVOLUTION_ENABLED` is valid for Parquet
files as well so removing it is not correct imo.
Also, `ScanRule` is called at planning time wh
codecov-commenter commented on PR #1723:
URL:
https://github.com/apache/datafusion-comet/pull/1723#issuecomment-2864777078
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1723?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
huaxingao commented on code in PR #1723:
URL: https://github.com/apache/datafusion-comet/pull/1723#discussion_r2080636065
##
common/src/main/java/org/apache/comet/parquet/Utils.java:
##
@@ -28,33 +28,33 @@
public class Utils {
- /** This method is called from Apache Iceber
10 matches
Mail list logo
