andygrove merged PR #1483:
URL: https://github.com/apache/datafusion-comet/pull/1483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove commented on PR #1483:
URL:
https://github.com/apache/datafusion-comet/pull/1483#issuecomment-2738004391
> This change looks good to me. It makes sense to not run these tests for
`native_datafusion` if we're falling back anyway. Do you have a good example of
a test or query where
andygrove commented on PR #1483:
URL:
https://github.com/apache/datafusion-comet/pull/1483#issuecomment-2738005266
Thanks for the review @parthchandra and @mbutrovich
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
andygrove commented on PR #1483:
URL:
https://github.com/apache/datafusion-comet/pull/1483#issuecomment-2737541255
@mbutrovich Could you take a look as well since this disables some tests for
`native_datafusion` exec.
--
This is an automated message from the Apache Git Service.
To respon
parthchandra commented on code in PR #1483:
URL: https://github.com/apache/datafusion-comet/pull/1483#discussion_r1999846503
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -188,69 +185,62 @@ class CometSparkSessionExtensions
sc
andygrove commented on code in PR #1483:
URL: https://github.com/apache/datafusion-comet/pull/1483#discussion_r1999438466
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -188,69 +185,62 @@ class CometSparkSessionExtensions
scanE
andygrove commented on code in PR #1483:
URL: https://github.com/apache/datafusion-comet/pull/1483#discussion_r1999378679
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -188,69 +185,62 @@ class CometSparkSessionExtensions
scanE
parthchandra commented on code in PR #1483:
URL: https://github.com/apache/datafusion-comet/pull/1483#discussion_r1999359044
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -188,69 +185,62 @@ class CometSparkSessionExtensions
sc
andygrove commented on PR #1483:
URL:
https://github.com/apache/datafusion-comet/pull/1483#issuecomment-2729501003
@mbutrovich @parthchandra This is now ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
