Re: [PR] fix: Fix data race in memory profiling [datafusion-comet]

2025-05-12 Thread via GitHub
andygrove merged PR #1727: URL: https://github.com/apache/datafusion-comet/pull/1727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] fix: Fix data race in memory profiling [datafusion-comet]

2025-05-12 Thread via GitHub
comphead commented on code in PR #1727: URL: https://github.com/apache/datafusion-comet/pull/1727#discussion_r2085157238 ## spark/src/main/java/org/apache/spark/CometTaskMemoryManager.java: ## @@ -30,36 +34,41 @@ * memory manager. This assumes Spark's off-heap memory mode is e

Re: [PR] fix: Fix data race in memory profiling [datafusion-comet]

2025-05-12 Thread via GitHub
comphead commented on code in PR #1727: URL: https://github.com/apache/datafusion-comet/pull/1727#discussion_r2085153843 ## spark/src/main/java/org/apache/spark/CometTaskMemoryManager.java: ## @@ -30,36 +34,41 @@ * memory manager. This assumes Spark's off-heap memory mode is e

Re: [PR] fix: Fix data race in memory profiling [datafusion-comet]

2025-05-12 Thread via GitHub
andygrove commented on code in PR #1727: URL: https://github.com/apache/datafusion-comet/pull/1727#discussion_r2084735443 ## spark/src/main/java/org/apache/spark/CometTaskMemoryManager.java: ## @@ -30,36 +34,41 @@ * memory manager. This assumes Spark's off-heap memory mode is

Re: [PR] fix: Fix data race in memory profiling [datafusion-comet]

2025-05-12 Thread via GitHub
wForget commented on code in PR #1727: URL: https://github.com/apache/datafusion-comet/pull/1727#discussion_r2083780711 ## spark/src/main/java/org/apache/spark/CometTaskMemoryManager.java: ## @@ -30,36 +34,41 @@ * memory manager. This assumes Spark's off-heap memory mode is en

Re: [PR] fix: Fix data race in memory profiling [datafusion-comet]

2025-05-11 Thread via GitHub
wForget commented on code in PR #1727: URL: https://github.com/apache/datafusion-comet/pull/1727#discussion_r2083780711 ## spark/src/main/java/org/apache/spark/CometTaskMemoryManager.java: ## @@ -30,36 +34,41 @@ * memory manager. This assumes Spark's off-heap memory mode is en

Re: [PR] fix: Fix data race in memory profiling [datafusion-comet]

2025-05-09 Thread via GitHub
parthchandra commented on code in PR #1727: URL: https://github.com/apache/datafusion-comet/pull/1727#discussion_r2082639273 ## spark/src/main/java/org/apache/spark/CometTaskMemoryManager.java: ## @@ -30,36 +34,41 @@ * memory manager. This assumes Spark's off-heap memory mode

Re: [PR] fix: Fix data race in memory profiling [datafusion-comet]

2025-05-09 Thread via GitHub
codecov-commenter commented on PR #1727: URL: https://github.com/apache/datafusion-comet/pull/1727#issuecomment-2868000912 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1727?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca