Re: [PR] fix: Fall back to Spark for distinct aggregates [datafusion-comet]

2025-01-13 Thread via GitHub
andygrove merged PR #1262: URL: https://github.com/apache/datafusion-comet/pull/1262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] fix: Fall back to Spark for distinct aggregates [datafusion-comet]

2025-01-13 Thread via GitHub
andygrove commented on PR #1262: URL: https://github.com/apache/datafusion-comet/pull/1262#issuecomment-2587330496 Thanks for the review @huaxingao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] fix: Fall back to Spark for distinct aggregates [datafusion-comet]

2025-01-10 Thread via GitHub
andygrove commented on code in PR #1262: URL: https://github.com/apache/datafusion-comet/pull/1262#discussion_r1911777608 ## spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala: ## @@ -974,7 +974,8 @@ class CometAggregateSuite extends CometTestBase with Adaptiv

Re: [PR] fix: Fall back to Spark for distinct aggregates [datafusion-comet]

2025-01-10 Thread via GitHub
andygrove commented on code in PR #1262: URL: https://github.com/apache/datafusion-comet/pull/1262#discussion_r1911770443 ## spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala: ## @@ -974,7 +974,8 @@ class CometAggregateSuite extends CometTestBase with Adaptiv

Re: [PR] fix: Fall back to Spark for distinct aggregates [datafusion-comet]

2025-01-10 Thread via GitHub
codecov-commenter commented on PR #1262: URL: https://github.com/apache/datafusion-comet/pull/1262#issuecomment-2584940287 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1262?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] fix: Fall back to Spark for distinct aggregates [datafusion-comet]

2025-01-10 Thread via GitHub
andygrove commented on code in PR #1262: URL: https://github.com/apache/datafusion-comet/pull/1262#discussion_r1911767513 ## spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala: ## @@ -974,7 +974,8 @@ class CometAggregateSuite extends CometTestBase with Adaptiv

Re: [PR] fix: Fall back to Spark for distinct aggregates [datafusion-comet]

2025-01-10 Thread via GitHub
comphead commented on code in PR #1262: URL: https://github.com/apache/datafusion-comet/pull/1262#discussion_r1911745757 ## spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala: ## @@ -974,7 +974,8 @@ class CometAggregateSuite extends CometTestBase with Adaptive

Re: [PR] fix: Fall back to Spark for distinct aggregates [datafusion-comet]

2025-01-10 Thread via GitHub
comphead commented on code in PR #1262: URL: https://github.com/apache/datafusion-comet/pull/1262#discussion_r1911726694 ## spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala: ## @@ -974,7 +974,8 @@ class CometAggregateSuite extends CometTestBase with Adaptive