github-actions[bot] closed pull request #1736: feat: use edition 2024
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
github-actions[bot] commented on PR #1736:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1736#issuecomment-2831740340
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or
alamb commented on PR #1736:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1736#issuecomment-2679691606
> Adding an MSRV sounds good to me!
Filed an issue to track:
- https://github.com/apache/datafusion-sqlparser-rs/issues/1744
--
This is an automated message from
iffyio commented on PR #1736:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1736#issuecomment-2677624981
Adding an MSRV sounds good to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb commented on PR #1736:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1736#issuecomment-2676808035
🤔 interestingly we don't seem to have an MSRV policy in this crate (at
least not that I could find in
https://github.com/apache/datafusion-sqlparser-rs/blob/main/README.md
iffyio commented on PR #1736:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1736#issuecomment-2674478094
Oh good point, yeah it does look like MSRV is 1.85 for 2024 edition, did a
quick test
```
Caused by:
feature `edition2024` is required
The package requi
alamb commented on code in PR #1736:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1736#discussion_r1965389503
##
Cargo.toml:
##
@@ -30,7 +30,7 @@ include = [
"Cargo.toml",
"LICENSE.TXT",
]
-edition = "2021"
+edition = "2024"
Review Comment:
my only
iajoiner commented on PR #1736:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1736#issuecomment-2673750295
@iffyio Yes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
iffyio commented on PR #1736:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1736#issuecomment-2673610757
@iajoiner could you take a look at the ci failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
