Re: [PR] feat: support inner iejoin [datafusion]

2025-04-18 Thread via GitHub
github-actions[bot] closed pull request #12754: feat: support inner iejoin URL: https://github.com/apache/datafusion/pull/12754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feat: support inner iejoin [datafusion]

2025-04-09 Thread via GitHub
github-actions[bot] commented on PR #12754: URL: https://github.com/apache/datafusion/pull/12754#issuecomment-2791365482 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] feat: support inner iejoin [datafusion]

2024-12-29 Thread via GitHub
my-vegetable-has-exploded commented on PR #12754: URL: https://github.com/apache/datafusion/pull/12754#issuecomment-2564720663 > I'm planning on taking a look at this over the next week or so, but it will take a little time for me to get up to speed on the details of what you're trying to d

Re: [PR] feat: support inner iejoin [datafusion]

2024-12-23 Thread via GitHub
timsaucer commented on PR #12754: URL: https://github.com/apache/datafusion/pull/12754#issuecomment-2560224119 I'm planning on taking a look at this over the next week or so, but it will take a little time for me to get up to speed on the details of what you're trying to do here. Can you ad

Re: [PR] feat: support inner iejoin [datafusion]

2024-12-21 Thread via GitHub
github-actions[bot] commented on PR #12754: URL: https://github.com/apache/datafusion/pull/12754#issuecomment-2558299074 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] feat: support inner iejoin [datafusion]

2024-10-22 Thread via GitHub
my-vegetable-has-exploded commented on PR #12754: URL: https://github.com/apache/datafusion/pull/12754#issuecomment-2429057021 > It's still _input_size^2_ complexity, however the _N^2_ step (step 3) is just looping through a bit array, it's way more efficient than do _N^2_ join condition ev

Re: [PR] feat: support inner iejoin [datafusion]

2024-10-21 Thread via GitHub
2010YOUY01 commented on PR #12754: URL: https://github.com/apache/datafusion/pull/12754#issuecomment-2426446395 Really impressive work! 1. I suggest opening another PR for benchmarks only, it can get merged easily and also help attract more attention. 2. I have a question: (jus

Re: [PR] feat: support inner iejoin [datafusion]

2024-10-18 Thread via GitHub
my-vegetable-has-exploded commented on PR #12754: URL: https://github.com/apache/datafusion/pull/12754#issuecomment-2421874148 ptal @xudong963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] feat: support inner iejoin [datafusion]

2024-10-16 Thread via GitHub
my-vegetable-has-exploded commented on code in PR #12754: URL: https://github.com/apache/datafusion/pull/12754#discussion_r1803019898 ## datafusion/physical-plan/src/joins/ie_join.rs: ## @@ -0,0 +1,1160 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

Re: [PR] feat: support inner iejoin [datafusion]

2024-10-16 Thread via GitHub
my-vegetable-has-exploded commented on code in PR #12754: URL: https://github.com/apache/datafusion/pull/12754#discussion_r1803019898 ## datafusion/physical-plan/src/joins/ie_join.rs: ## @@ -0,0 +1,1160 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

Re: [PR] feat: support inner iejoin [datafusion]

2024-10-16 Thread via GitHub
my-vegetable-has-exploded commented on code in PR #12754: URL: https://github.com/apache/datafusion/pull/12754#discussion_r1803019898 ## datafusion/physical-plan/src/joins/ie_join.rs: ## @@ -0,0 +1,1160 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

Re: [PR] feat: support inner iejoin [datafusion]

2024-10-13 Thread via GitHub
my-vegetable-has-exploded commented on PR #12754: URL: https://github.com/apache/datafusion/pull/12754#issuecomment-2409003636 ![btree-perf](https://github.com/user-attachments/assets/b5728eec-eab7-43bf-ab50-9984b9b2d39a) It seems the main cost is sorting. -- This is an automated m

Re: [PR] feat: support inner iejoin [datafusion]

2024-10-13 Thread via GitHub
my-vegetable-has-exploded commented on code in PR #12754: URL: https://github.com/apache/datafusion/pull/12754#discussion_r1798196952 ## datafusion/physical-plan/src/joins/ie_join.rs: ## @@ -0,0 +1,1133 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor