Re: [PR] feat: scalar regex match physical expr [datafusion]

2025-02-26 Thread via GitHub
github-actions[bot] closed pull request #12270: feat: scalar regex match physical expr URL: https://github.com/apache/datafusion/pull/12270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] feat: scalar regex match physical expr [datafusion]

2025-02-19 Thread via GitHub
github-actions[bot] commented on PR #12270: URL: https://github.com/apache/datafusion/pull/12270#issuecomment-2670230447 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] feat: scalar regex match physical expr [datafusion]

2024-12-15 Thread via GitHub
zhuliquan commented on PR #12270: URL: https://github.com/apache/datafusion/pull/12270#issuecomment-2543947569 > I wonder if we can see improvements on queries in benchmarks with scalar regexes, e.g. clickbench? hello, @Dandandan I have write a benchmark for testing scalar regex match

Re: [PR] feat: scalar regex match physical expr [datafusion]

2024-12-06 Thread via GitHub
zhuliquan closed pull request #12270: feat: scalar regex match physical expr URL: https://github.com/apache/datafusion/pull/12270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feat: scalar regex match physical expr [datafusion]

2024-12-04 Thread via GitHub
zhuliquan commented on PR #12270: URL: https://github.com/apache/datafusion/pull/12270#issuecomment-2517838711 > I wonder if we can see improvements on queries in benchmarks with scalar regexes, e.g. clickbench? Emm, It means that we should add some regex matching queries in benchmark

Re: [PR] feat: scalar regex match physical expr [datafusion]

2024-12-03 Thread via GitHub
Dandandan commented on PR #12270: URL: https://github.com/apache/datafusion/pull/12270#issuecomment-2515338163 I wonder if we can see improvements on queries in benchmarks with scalar regexes, e.g. clickbench? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] feat: scalar regex match physical expr [datafusion]

2024-12-03 Thread via GitHub
zhuliquan commented on PR #12270: URL: https://github.com/apache/datafusion/pull/12270#issuecomment-2514990439 > Thank you for this PR @zhuliquan . Have you run any benchmarks that show this approach is noticeably faster than the existing approach? It makes sense that it would be faster as

Re: [PR] feat: scalar regex match physical expr [datafusion]

2024-09-17 Thread via GitHub
zhuliquan commented on PR #12270: URL: https://github.com/apache/datafusion/pull/12270#issuecomment-2356429661 > Thank you for this PR @zhuliquan . Have you run any benchmarks that show this approach is noticeably faster than the existing approach? It makes sense that it would be faster as

Re: [PR] feat: scalar regex match physical expr [datafusion]

2024-09-07 Thread via GitHub
alamb commented on PR #12270: URL: https://github.com/apache/datafusion/pull/12270#issuecomment-2335147328 Thank you for this PR @zhuliquan . Have you run any benchmarks that show this approach is noticeably faster than the existing approach? It makes sense that it would be faster as it do