timsaucer commented on PR #982:
URL:
https://github.com/apache/datafusion-python/pull/982#issuecomment-2708552064
Thanks, Kyle. More generally I’ll see about the impact of turning on all the
rules and then removing a few specifically as needed
--
This is an automated message from the Apa
kylebarron commented on PR #982:
URL:
https://github.com/apache/datafusion-python/pull/982#issuecomment-2708499224
There needs to be an initial import `from __future__ import annotations` on
the first line to be able to use `|` typing syntax.
There are ruff rules to check this and we
Spaarsh commented on PR #982:
URL:
https://github.com/apache/datafusion-python/pull/982#issuecomment-2708491224
Key Points:
1. ```|``` operator not supported for python < 3.10, anyone pulling the main
post merge will not be able to use ```SessionContext``` at all
2. ```global_ctx``` a
timsaucer merged PR #982:
URL: https://github.com/apache/datafusion-python/pull/982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
timsaucer commented on PR #982:
URL:
https://github.com/apache/datafusion-python/pull/982#issuecomment-2708291557
I added a few lines to the documentation, rebased, and applied updated ruff
formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message
kylebarron commented on code in PR #982:
URL: https://github.com/apache/datafusion-python/pull/982#discussion_r1904778623
##
python/datafusion/io.py:
##
@@ -0,0 +1,181 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. Se
kevinjqliu commented on code in PR #982:
URL: https://github.com/apache/datafusion-python/pull/982#discussion_r1904776793
##
python/datafusion/io.py:
##
@@ -0,0 +1,181 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. Se
kylebarron commented on code in PR #982:
URL: https://github.com/apache/datafusion-python/pull/982#discussion_r1904717182
##
python/datafusion/io.py:
##
@@ -0,0 +1,181 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. Se
