Re: [PR] feat: Implementation of udf and udaf decorator [datafusion-python]

2025-03-08 Thread via GitHub
timsaucer merged PR #1040: URL: https://github.com/apache/datafusion-python/pull/1040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

Re: [PR] feat: Implementation of udf and udaf decorator [datafusion-python]

2025-03-08 Thread via GitHub
timsaucer commented on PR #1040: URL: https://github.com/apache/datafusion-python/pull/1040#issuecomment-2708284548 Thank you for all of your work on this. It looks like we now have a conflict that needs to be resolved since `main` updated. I've started the CI pipeline but it also looks li

Re: [PR] feat: Implementation of udf and udaf decorator [datafusion-python]

2025-03-03 Thread via GitHub
CrystalZhou0529 commented on PR #1040: URL: https://github.com/apache/datafusion-python/pull/1040#issuecomment-2695075735 no problem! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat: Implementation of udf and udaf decorator [datafusion-python]

2025-03-03 Thread via GitHub
timsaucer commented on PR #1040: URL: https://github.com/apache/datafusion-python/pull/1040#issuecomment-2695054328 This is looking very nice. Would you mind if I do some wordsmithing on the documentation? I'll also run the work flows now. -- This is an automated message from the Apache

Re: [PR] feat: Implementation of udf and udaf decorator [datafusion-python]

2025-03-03 Thread via GitHub
CrystalZhou0529 commented on PR #1040: URL: https://github.com/apache/datafusion-python/pull/1040#issuecomment-2695035830 @timsaucer Hi, I borrowed your suggested idea and managed to get it work! I also used llm a bit to write the documentation. I hope it's not too confusing for users to u

Re: [PR] feat: Implementation of udf and udaf decorator [datafusion-python]

2025-03-03 Thread via GitHub
CrystalZhou0529 commented on PR #1040: URL: https://github.com/apache/datafusion-python/pull/1040#issuecomment-2694819663 Thanks for your suggestion! I totally agree that `@udf` is a better name. I'll experiment it and provide an update soon! -- This is an automated message from the Apac