andygrove closed pull request #616: feat: ANSI support for Add
URL: https://github.com/apache/datafusion-comet/pull/616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
andygrove commented on PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#issuecomment-2960624710
I am closing this PR since it has not been active lately. Feel free to
re-open if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message
planga82 commented on PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#issuecomment-827653
Thank you very much @andygrove for the explanation and the PR. In addition
to @dharanad question
In Spark we have three different behaviors
ANSI mode disable --> Sa
dharanad commented on PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#issuecomment-2221940686
> @planga82 Please see [apache/datafusion#
v](https://github.com/apache/datafusion/pull/11400) that I just created against
DataFusion, which possibly gives us most of what we need
andygrove commented on PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#issuecomment-2221247715
@planga82 Please see https://github.com/apache/datafusion/pull/11400 that I
just created against DataFusion, which possibly gives us most of what we need,
although the same princ
andygrove commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1672731981
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,211 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contrib
andygrove commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1672729885
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,211 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contrib
andygrove commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1672728617
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contrib
dharanad commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1670855040
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
andygrove commented on PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#issuecomment-2217922631
Thanks for the contribution @planga82. I am reviewing this today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dharanad commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1668351284
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
planga82 commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1668815147
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
planga82 commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1668815147
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
dharanad commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1668351284
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
dharanad commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1668297829
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
planga82 commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1667141077
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
planga82 commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1667140189
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
planga82 commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1664848177
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
eejbyfeldt commented on code in PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#discussion_r1664684744
##
core/src/execution/datafusion/expressions/binary.rs:
##
@@ -0,0 +1,202 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
19 matches
Mail list logo
