Re: [PR] feat/improve ruff test coverage [datafusion-python]

2025-03-15 Thread via GitHub
timsaucer commented on PR #1055: URL: https://github.com/apache/datafusion-python/pull/1055#issuecomment-2710849717 #1056 contains the follow on work to apply additional rules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] feat/improve ruff test coverage [datafusion-python]

2025-03-15 Thread via GitHub
kevinjqliu commented on code in PR #1055: URL: https://github.com/apache/datafusion-python/pull/1055#discussion_r1991919996 ## uv.lock: ## @@ -351,7 +351,6 @@ wheels = [ [[package]] name = "datafusion" -version = "44.0.0" Review Comment: i cant find any reasons why this

Re: [PR] feat/improve ruff test coverage [datafusion-python]

2025-03-12 Thread via GitHub
timsaucer commented on code in PR #1055: URL: https://github.com/apache/datafusion-python/pull/1055#discussion_r1992072698 ## pyproject.toml: ## @@ -24,7 +24,7 @@ name = "datafusion" description = "Build and run queries against data" readme = "README.md" license = { file = "

Re: [PR] feat/improve ruff test coverage [datafusion-python]

2025-03-12 Thread via GitHub
timsaucer merged PR #1055: URL: https://github.com/apache/datafusion-python/pull/1055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

Re: [PR] feat/improve ruff test coverage [datafusion-python]

2025-03-10 Thread via GitHub
CrystalZhou0529 commented on code in PR #1055: URL: https://github.com/apache/datafusion-python/pull/1055#discussion_r1988370240 ## python/datafusion/udf.py: ## @@ -111,7 +111,27 @@ def __call__(self, *args: Expr) -> Expr: args_raw = [arg.expr for arg in args]

Re: [PR] feat/improve ruff test coverage [datafusion-python]

2025-03-09 Thread via GitHub
timsaucer commented on PR #1055: URL: https://github.com/apache/datafusion-python/pull/1055#issuecomment-2709187047 @CrystalZhou0529 would you mind reviewing the changes I made to `udf` and `udaf`? -- This is an automated message from the Apache Git Service. To respond to the message, p