Re: [PR] chore: refactor v2 scan conversion [datafusion-comet]

2025-04-10 Thread via GitHub
comphead commented on code in PR #1621: URL: https://github.com/apache/datafusion-comet/pull/1621#discussion_r2036318198 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -197,8 +133,7 @@ class CometSparkSessionExtensions if (COMET_DPP_FA

Re: [PR] chore: refactor v2 scan conversion [datafusion-comet]

2025-04-10 Thread via GitHub
andygrove merged PR #1621: URL: https://github.com/apache/datafusion-comet/pull/1621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] chore: refactor v2 scan conversion [datafusion-comet]

2025-04-10 Thread via GitHub
kazuyukitanimura commented on code in PR #1621: URL: https://github.com/apache/datafusion-comet/pull/1621#discussion_r2037832773 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -197,8 +133,7 @@ class CometSparkSessionExtensions if (COME

Re: [PR] chore: refactor v2 scan conversion [datafusion-comet]

2025-04-09 Thread via GitHub
comphead commented on code in PR #1621: URL: https://github.com/apache/datafusion-comet/pull/1621#discussion_r2036316165 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -236,16 +171,70 @@ class CometSparkSessionExtensions CometScanE

Re: [PR] chore: refactor v2 scan conversion [datafusion-comet]

2025-04-09 Thread via GitHub
parthchandra commented on code in PR #1621: URL: https://github.com/apache/datafusion-comet/pull/1621#discussion_r2036258826 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -246,6 +183,65 @@ class CometSparkSessionExtensions } } + pri

Re: [PR] chore: refactor v2 scan conversion [datafusion-comet]

2025-04-09 Thread via GitHub
andygrove commented on code in PR #1621: URL: https://github.com/apache/datafusion-comet/pull/1621#discussion_r2036189365 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -246,6 +183,65 @@ class CometSparkSessionExtensions } } + privat

Re: [PR] chore: refactor v2 scan conversion [datafusion-comet]

2025-04-09 Thread via GitHub
parthchandra commented on code in PR #1621: URL: https://github.com/apache/datafusion-comet/pull/1621#discussion_r2036049975 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -246,6 +183,65 @@ class CometSparkSessionExtensions } } + pri

Re: [PR] chore: refactor v2 scan conversion [datafusion-comet]

2025-04-09 Thread via GitHub
andygrove commented on code in PR #1621: URL: https://github.com/apache/datafusion-comet/pull/1621#discussion_r2035921195 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -246,6 +183,65 @@ class CometSparkSessionExtensions } } + privat

Re: [PR] chore: refactor v2 scan conversion [datafusion-comet]

2025-04-09 Thread via GitHub
andygrove commented on code in PR #1621: URL: https://github.com/apache/datafusion-comet/pull/1621#discussion_r2035880871 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -246,6 +183,65 @@ class CometSparkSessionExtensions } } + privat

Re: [PR] chore: refactor v2 scan conversion [datafusion-comet]

2025-04-09 Thread via GitHub
kazuyukitanimura commented on code in PR #1621: URL: https://github.com/apache/datafusion-comet/pull/1621#discussion_r2035865358 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -246,6 +183,65 @@ class CometSparkSessionExtensions } } +

Re: [PR] chore: refactor v2 scan conversion [datafusion-comet]

2025-04-07 Thread via GitHub
codecov-commenter commented on PR #1621: URL: https://github.com/apache/datafusion-comet/pull/1621#issuecomment-2784422462 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1621?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca