Re: [PR] chore: Prepare for DataFusion 47.0.0 [datafusion-comet]

2025-04-10 Thread via GitHub
andygrove commented on PR #1563: URL: https://github.com/apache/datafusion-comet/pull/1563#issuecomment-2794672946 Some aggregate tests started to fail. I filed an issue in DataFusion https://github.com/apache/datafusion/issues/15676 -- This is an automated message from the Apache Git Se

Re: [PR] chore: Prepare for DataFusion 47.0.0 [datafusion-comet]

2025-04-07 Thread via GitHub
andygrove commented on PR #1563: URL: https://github.com/apache/datafusion-comet/pull/1563#issuecomment-2784761501 I ran TPC-H benchmarks locally and do not see any noticeable difference in performance -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] chore: Prepare for DataFusion 47.0.0 [datafusion-comet]

2025-03-21 Thread via GitHub
codecov-commenter commented on PR #1563: URL: https://github.com/apache/datafusion-comet/pull/1563#issuecomment-2744428387 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1563?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] chore: Prepare for DataFusion 47.0.0 [datafusion-comet]

2025-03-21 Thread via GitHub
andygrove commented on code in PR #1563: URL: https://github.com/apache/datafusion-comet/pull/1563#discussion_r2008287770 ## native/core/src/parquet/schema_adapter.rs: ## @@ -216,57 +216,6 @@ impl SchemaMapper for SchemaMapping { let record_batch = RecordBatch::try_new_