Re: [PR] chore: Prepare 0.8.1 release [branch-0.8] [datafusion-comet]

2025-04-30 Thread via GitHub
andygrove merged PR #1699: URL: https://github.com/apache/datafusion-comet/pull/1699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] chore: Prepare 0.8.1 release [branch-0.8] [datafusion-comet]

2025-04-30 Thread via GitHub
andygrove commented on PR #1699: URL: https://github.com/apache/datafusion-comet/pull/1699#issuecomment-2842678170 @parthchandra @huaxingao Hopefully CI will pass this time - could I get a review? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] chore: Prepare 0.8.1 release [branch-0.8] [datafusion-comet]

2025-04-30 Thread via GitHub
andygrove commented on code in PR #1699: URL: https://github.com/apache/datafusion-comet/pull/1699#discussion_r2068974642 ## .github/workflows/benchmark.yml: ## @@ -70,6 +70,7 @@ jobs: with: path: ./tpcds-sf-1 key: tpcds-${{ hashFiles('.github/work

Re: [PR] chore: Prepare 0.8.1 release [branch-0.8] [datafusion-comet]

2025-04-30 Thread via GitHub
andygrove commented on PR #1699: URL: https://github.com/apache/datafusion-comet/pull/1699#issuecomment-2842407052 hmm that did not work ``` /usr/bin/docker exec f44b663cc7dcb9c368890c652d8e41fd738b91080e1f7e561236b850254ac78b sh -c "cat /etc/*release | grep ^ID" Error: Faile

Re: [PR] chore: Prepare 0.8.1 release [branch-0.8] [datafusion-comet]

2025-04-30 Thread via GitHub
andygrove commented on PR #1699: URL: https://github.com/apache/datafusion-comet/pull/1699#issuecomment-2842396751 > @andygrove CI failed. Could you please take a look? I deleted caches and am re-running the failed jobs -- This is an automated message from the Apache Git Service. T

Re: [PR] chore: Prepare 0.8.1 release [branch-0.8] [datafusion-comet]

2025-04-30 Thread via GitHub
huaxingao commented on PR #1699: URL: https://github.com/apache/datafusion-comet/pull/1699#issuecomment-2842133847 @andygrove CI failed. Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] chore: Prepare 0.8.1 release [branch-0.8] [datafusion-comet]

2025-04-29 Thread via GitHub
codecov-commenter commented on PR #1699: URL: https://github.com/apache/datafusion-comet/pull/1699#issuecomment-2840556859 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1699?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca