Re: [PR] chore: Change default Spark version to 3.5 [datafusion-comet]

2025-04-10 Thread via GitHub
andygrove merged PR #1620: URL: https://github.com/apache/datafusion-comet/pull/1620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] chore: Change default Spark version to 3.5 [datafusion-comet]

2025-04-09 Thread via GitHub
andygrove commented on code in PR #1620: URL: https://github.com/apache/datafusion-comet/pull/1620#discussion_r2035981075 ## .github/actions/setup-spark-builder/action.yaml: ## @@ -19,13 +19,11 @@ name: Setup Spark Builder description: 'Setup Apache Spark to run SQL tests' inp

Re: [PR] chore: Change default Spark version to 3.5 [datafusion-comet]

2025-04-09 Thread via GitHub
andygrove commented on code in PR #1620: URL: https://github.com/apache/datafusion-comet/pull/1620#discussion_r2035965475 ## pom.xml: ## Review Comment: I tried doing this, but it caused regressions in Spark 4 support, so I'd prefer to create a separate PR. I filed a track

Re: [PR] chore: Change default Spark version to 3.5 [datafusion-comet]

2025-04-09 Thread via GitHub
kazuyukitanimura commented on code in PR #1620: URL: https://github.com/apache/datafusion-comet/pull/1620#discussion_r2035772596 ## pom.xml: ## Review Comment: Should we update some of the versions hardcoded to match with the versions used for Spark 3.5? E.g. org.scalat

Re: [PR] chore: Change default Spark version to 3.5 [datafusion-comet]

2025-04-07 Thread via GitHub
codecov-commenter commented on PR #1620: URL: https://github.com/apache/datafusion-comet/pull/1620#issuecomment-2784210137 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1620?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca