jonahgao merged PR #14489:
URL: https://github.com/apache/datafusion/pull/14489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
jkosh44 commented on PR #14489:
URL: https://github.com/apache/datafusion/pull/14489#issuecomment-2637074517
> I think this PR is nicely implemented, commented and tested 🏆
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
alamb commented on code in PR #14489:
URL: https://github.com/apache/datafusion/pull/14489#discussion_r1942981686
##
datafusion/sqllogictest/test_files/array.slt:
##
@@ -1993,6 +1993,28 @@ select array_slice(arrow_cast(make_array(1, 2, 3, 4, 5),
'LargeList(Int64)'), 2,
[
jkosh44 commented on code in PR #14489:
URL: https://github.com/apache/datafusion/pull/14489#discussion_r1941739956
##
datafusion/functions-nested/src/extract.rs:
##
@@ -487,7 +487,17 @@ where
// 0 ~ len - 1
let adjusted_zero_index = if index < 0 {
