acking-you commented on PR #15475:
URL: https://github.com/apache/datafusion/pull/15475#issuecomment-2762006629
I have also made changes to the query in ClickBench:
[clickbench-pr](https://github.com/ClickHouse/ClickBench/pull/340)
@Dandandan @adriangb
--
This is an automated messag
Dandandan commented on PR #15475:
URL: https://github.com/apache/datafusion/pull/15475#issuecomment-2762979608
Thank you @acking-you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Dandandan merged PR #15475:
URL: https://github.com/apache/datafusion/pull/15475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
adriangb commented on PR #15475:
URL: https://github.com/apache/datafusion/pull/15475#issuecomment-2762100250
@Dandandan do you think we can merge this here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
adriangb commented on PR #15475:
URL: https://github.com/apache/datafusion/pull/15475#issuecomment-2761917991
> > Looks good to me. Since we're only ordering by this it shouldn't matter
that we order by an integer instead of a proper timestamp, ordering is
equivalent.
>
> Thank you v
acking-you commented on PR #15475:
URL: https://github.com/apache/datafusion/pull/15475#issuecomment-2761888661
> Looks good to me. Since we're only ordering by this it shouldn't matter
that we order by an integer instead of a proper timestamp, ordering is
equivalent.
Thank you very
Dandandan commented on PR #15475:
URL: https://github.com/apache/datafusion/pull/15475#issuecomment-2761610618
> Should we update the same query in the clickbench repo as well?
Yes, and we might rerun the queries as well (as `to_timestamp_seconds` takes
some time itself as well).
--
adriangb commented on PR #15475:
URL: https://github.com/apache/datafusion/pull/15475#issuecomment-2761603385
Should we update the same query in the clickbench repo as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
