github-actions[bot] closed pull request #13741: Support binary temporal
arithmetic with integers
URL: https://github.com/apache/datafusion/pull/13741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#issuecomment-2735135388
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
alamb commented on PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#issuecomment-2597024287
What is the status of this PR? Are we waiting on upstream changes in
arrow-rs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
milevin commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1885383953
##
datafusion/expr/src/expr_schema.rs:
##
@@ -453,6 +455,26 @@ impl ExprSchemable for Expr {
}
_ => Ok(Expr::Cast(Cast::new(Box::
jonahgao commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1885119711
##
datafusion/expr/src/expr_schema.rs:
##
@@ -453,6 +455,26 @@ impl ExprSchemable for Expr {
}
_ => Ok(Expr::Cast(Cast::new(Box:
alamb commented on PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#issuecomment-2542008198
FYI @jonahgao in case you would like to weigh in here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
findepi commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1881988070
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -186,6 +186,12 @@ fn signature(lhs: &DataType, op: &Operator, rhs:
&DataType) -> Result
milevin commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1881606531
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -1449,6 +1455,22 @@ fn null_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option {
}
}
milevin commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1881601707
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -1869,6 +1905,51 @@ mod tests {
Operator::Multiply,
DataType::Float64
milevin commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1881600889
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -1607,6 +1629,18 @@ mod tests {
}};
}
+/// Test coercion rules for assymetric bina
milevin commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1881598760
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -1607,6 +1629,18 @@ mod tests {
}};
}
+/// Test coercion rules for assymetric bina
milevin commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1881596978
##
datafusion/expr/src/expr_schema.rs:
##
@@ -453,6 +455,26 @@ impl ExprSchemable for Expr {
}
_ => Ok(Expr::Cast(Cast::new(Box::
findepi commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1881583324
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -1449,6 +1455,22 @@ fn null_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option {
}
}
13 matches
Mail list logo
