alamb merged PR #15468:
URL: https://github.com/apache/datafusion/pull/15468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on code in PR #15468:
URL: https://github.com/apache/datafusion/pull/15468#discussion_r2048964601
##
datafusion/functions-aggregate/src/average.rs:
##
@@ -399,6 +410,105 @@ impl
Accumulator for DecimalAvgAccumu
}
}
+/// An accumulator to compute the aver
shruti2522 commented on code in PR #15468:
URL: https://github.com/apache/datafusion/pull/15468#discussion_r2050599634
##
datafusion/sqllogictest/test_files/aggregate.slt:
##
@@ -4969,6 +4969,25 @@ select count(distinct column1), count(distinct column2)
from dict_test group by
shruti2522 commented on PR #15468:
URL: https://github.com/apache/datafusion/pull/15468#issuecomment-2811840204
> I think you need to update the signature of Avg to support the new type as
well
@alamb this one's ready for review whenever you get a chance.
--
This is an automated me
alamb commented on PR #15468:
URL: https://github.com/apache/datafusion/pull/15468#issuecomment-2783389939
Ping @shruti2522 -- this one looks pretty close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb commented on PR #15468:
URL: https://github.com/apache/datafusion/pull/15468#issuecomment-2783391065
I think you need to update the signature of Avg to support the new type as
well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
