Re: [PR] Simplify error handling in case.rs (#13990) [datafusion]

2025-01-09 Thread via GitHub
alamb commented on PR #14033: URL: https://github.com/apache/datafusion/pull/14033#issuecomment-2581281922 Thanks again @cj-zhukov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Simplify error handling in case.rs (#13990) [datafusion]

2025-01-09 Thread via GitHub
alamb merged PR #14033: URL: https://github.com/apache/datafusion/pull/14033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Simplify error handling in case.rs (#13990) [datafusion]

2025-01-09 Thread via GitHub
cj-zhukov commented on PR #14033: URL: https://github.com/apache/datafusion/pull/14033#issuecomment-2580372236 @alamb Andrew, thank you for feedback and useful advices. Really appreciate your work that helps me improve my Rust code. -- This is an automated message from the Apache Git Serv

Re: [PR] Simplify error handling in case.rs (#13990) [datafusion]

2025-01-08 Thread via GitHub
alamb commented on code in PR #14033: URL: https://github.com/apache/datafusion/pull/14033#discussion_r1907660263 ## datafusion/physical-expr/src/expressions/case.rs: ## @@ -369,11 +366,8 @@ impl CaseExpr { // evaluate when expression let when_value = self.when

Re: [PR] Simplify error handling in case.rs (#13990) [datafusion]

2025-01-07 Thread via GitHub
cj-zhukov commented on PR #14033: URL: https://github.com/apache/datafusion/pull/14033#issuecomment-2576860655 @alamb Andrew, I noticed the build fails unless I import `datafusion_common::DataFusionError`, which is not used in my PR changes but appears necessary for compatibility with the m

Re: [PR] Simplify error handling in case.rs (#13990) [datafusion]

2025-01-07 Thread via GitHub
alamb commented on PR #14033: URL: https://github.com/apache/datafusion/pull/14033#issuecomment-2575793893 Thank you @cj-zhukov ! It seems as if there is a compile error in this PR: https://github.com/apache/datafusion/actions/runs/12646530220/job/35237388507?pr=14033 ``` e