Re: [PR] Set aggregation hash seed [datafusion]

alamb commented on PR #16165: URL: https://github.com/apache/datafusion/pull/16165#issuecomment-2917168337 Thanks again @ctsk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Set aggregation hash seed [datafusion]

alamb merged PR #16165: URL: https://github.com/apache/datafusion/pull/16165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Set aggregation hash seed [datafusion]

alamb commented on PR #16165: URL: https://github.com/apache/datafusion/pull/16165#issuecomment-2917168057 Second performance run looks as good / better so let's merge this in! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Set aggregation hash seed [datafusion]

alamb commented on PR #16165: URL: https://github.com/apache/datafusion/pull/16165#issuecomment-2907785532 🤖: Benchmark completed Details ``` Comparing HEAD and fix_aggregation-seed Benchmark clickbench_extended.json

Re: [PR] Set aggregation hash seed [datafusion]

alamb commented on PR #16165: URL: https://github.com/apache/datafusion/pull/16165#issuecomment-290856 🤖 `./gh_compare_branch.sh` [Benchmark Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh) Running Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun

Re: [PR] Set aggregation hash seed [datafusion]

alamb commented on PR #16165: URL: https://github.com/apache/datafusion/pull/16165#issuecomment-290827 🤖: Benchmark completed Details ``` Comparing HEAD and fix_aggregation-seed Benchmark clickbench_extended.json

Re: [PR] Set aggregation hash seed [datafusion]

alamb commented on PR #16165: URL: https://github.com/apache/datafusion/pull/16165#issuecomment-2907771160 🤖 `./gh_compare_branch.sh` [Benchmark Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh) Running Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun

Re: [PR] Set aggregation hash seed [datafusion]

alamb commented on PR #16165: URL: https://github.com/apache/datafusion/pull/16165#issuecomment-2907770923 I am surprised this shows any performance difference. I will rerun and see if I can reproduce -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Set aggregation hash seed [datafusion]

alamb commented on PR #16165: URL: https://github.com/apache/datafusion/pull/16165#issuecomment-2906808852 🤖: Benchmark completed Details ``` Comparing HEAD and fix_aggregation-seed Benchmark clickbench_extended.json

Re: [PR] Set aggregation hash seed [datafusion]

alamb commented on PR #16165: URL: https://github.com/apache/datafusion/pull/16165#issuecomment-2906787528 🤖 `./gh_compare_branch.sh` [Benchmark Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch.sh) Running Linux aal-dev 6.11.0-1013-gcp #13~24.04.1-Ubun

Re: [PR] Set aggregation hash seed [datafusion]

alamb commented on code in PR #16165: URL: https://github.com/apache/datafusion/pull/16165#discussion_r2105793257 ## datafusion/physical-plan/src/aggregates/mod.rs: ## @@ -57,6 +57,10 @@ mod row_hash; mod topk; mod topk_stream; +/// Hard-coded seed for aggregations to ensure