Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

alamb commented on PR #14290: URL: https://github.com/apache/datafusion/pull/14290#issuecomment-2640529650 Thanks again @Omega359 -- let's get this one in -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

alamb merged PR #14290: URL: https://github.com/apache/datafusion/pull/14290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

Omega359 commented on PR #14290: URL: https://github.com/apache/datafusion/pull/14290#issuecomment-2636908753 I have no clue where that Cargo.toml-e file is coming from, I don't see that locally -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

alamb commented on PR #14290: URL: https://github.com/apache/datafusion/pull/14290#issuecomment-2636866013 > I am going to test running this with https://github.com/apache/datafusion/pull/14371 too to see if that results in expected result change It worked! See PR here: - h

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

Omega359 commented on PR #14290: URL: https://github.com/apache/datafusion/pull/14290#issuecomment-2632087689 I am perplexed. My best guess is the find command isn't quite the same as it's on linux and isn't working as expected on a mac. Just a guess though. I don't have a mac that I can te

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

Omega359 commented on PR #14290: URL: https://github.com/apache/datafusion/pull/14290#issuecomment-2631985204 I think I found a decent alternative to using sed that should work. it seems the script isn't updating/finding the datafusion-testing for some reason for you. Not sure why yet

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

alamb commented on PR #14290: URL: https://github.com/apache/datafusion/pull/14290#issuecomment-2631394971 > Ready for 2nd round of testing... Hoping to try it later today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

Omega359 commented on PR #14290: URL: https://github.com/apache/datafusion/pull/14290#issuecomment-2628468798 Ready for 2nd round of testing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

Omega359 commented on code in PR #14290: URL: https://github.com/apache/datafusion/pull/14290#discussion_r1938025677 ## datafusion/sqllogictest/regenerate_sqlite_files.sh: ## @@ -0,0 +1,179 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

Omega359 commented on code in PR #14290: URL: https://github.com/apache/datafusion/pull/14290#discussion_r1934713735 ## datafusion/sqllogictest/regenerate_sqlite_files.sh: ## @@ -0,0 +1,179 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

Omega359 commented on code in PR #14290: URL: https://github.com/apache/datafusion/pull/14290#discussion_r1934307461 ## datafusion/sqllogictest/regenerate_sqlite_files.sh: ## @@ -0,0 +1,179 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

Omega359 commented on code in PR #14290: URL: https://github.com/apache/datafusion/pull/14290#discussion_r1934302894 ## datafusion/sqllogictest/regenerate_sqlite_files.sh: ## @@ -0,0 +1,179 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

Omega359 commented on PR #14290: URL: https://github.com/apache/datafusion/pull/14290#issuecomment-2622360492 I was worried that macs would be troublesome for this script. I'll try and adjust things for that platform. the difference in sed is ... unfortunate. The postgres errors might

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

alamb commented on code in PR #14290: URL: https://github.com/apache/datafusion/pull/14290#discussion_r1934283379 ## datafusion/sqllogictest/regenerate_sqlite_files.sh: ## @@ -0,0 +1,179 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Script and documentation for regenerating sqlite test files [datafusion]

alamb commented on PR #14290: URL: https://github.com/apache/datafusion/pull/14290#issuecomment-2622029735 I plan to test this (by way of review) later today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov