Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2025-02-22 Thread via GitHub
github-actions[bot] closed pull request #13420: Refactor signatures for lpad, rpad, left, and right URL: https://github.com/apache/datafusion/pull/13420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2025-02-14 Thread via GitHub
github-actions[bot] commented on PR #13420: URL: https://github.com/apache/datafusion/pull/13420#issuecomment-2660627372 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-12-16 Thread via GitHub
jayzhan211 commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1886769687 ## datafusion/sqllogictest/test_files/scalar.slt: ## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string; ---

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-12-14 Thread via GitHub
Omega359 commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1885408928 ## datafusion/sqllogictest/test_files/scalar.slt: ## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string;

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-11-19 Thread via GitHub
jiashenC commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1849662134 ## datafusion/sqllogictest/test_files/scalar.slt: ## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string;

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-11-17 Thread via GitHub
jiashenC commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1845563851 ## datafusion/sqllogictest/test_files/scalar.slt: ## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string;

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-11-16 Thread via GitHub
jayzhan211 commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1845264760 ## datafusion/sqllogictest/test_files/scalar.slt: ## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string; ---

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-11-16 Thread via GitHub
jiashenC commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1845102590 ## datafusion/sqllogictest/test_files/scalar.slt: ## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string;

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-11-15 Thread via GitHub
jiashenC commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1844388835 ## datafusion/sqllogictest/test_files/scalar.slt: ## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string;

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-11-15 Thread via GitHub
jayzhan211 commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1844728918 ## datafusion/sqllogictest/test_files/scalar.slt: ## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string; ---

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-11-15 Thread via GitHub
alamb commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1844325454 ## datafusion/sqllogictest/test_files/scalar.slt: ## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string; lo

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-11-15 Thread via GitHub
Omega359 commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1843978277 ## datafusion/sqllogictest/test_files/scalar.slt: ## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string;

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-11-15 Thread via GitHub
jayzhan211 commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1843495369 ## datafusion/sqllogictest/test_files/scalar.slt: ## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string; ---

Re: [PR] Refactor signatures for lpad, rpad, left, and right [datafusion]

2024-11-14 Thread via GitHub
Omega359 commented on PR #13420: URL: https://github.com/apache/datafusion/pull/13420#issuecomment-2477261734 You can run ``` cargo test --test sqllogictests``` locally to reproduce the test failures. -- This is an automated message from the Apache Git Service. To respond to