Re: [PR] Refactor file schema type coercions [datafusion]

2025-04-04 Thread via GitHub
xudong963 commented on code in PR #15268: URL: https://github.com/apache/datafusion/pull/15268#discussion_r248516 ## datafusion/datasource-parquet/src/file_format.rs: ## @@ -465,45 +465,103 @@ impl FileFormat for ParquetFormat { } } -/// Coerces the file schema if th

Re: [PR] Refactor file schema type coercions [datafusion]

2025-03-18 Thread via GitHub
xudong963 merged PR #15268: URL: https://github.com/apache/datafusion/pull/15268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@data

Re: [PR] Refactor file schema type coercions [datafusion]

2025-03-18 Thread via GitHub
xudong963 commented on PR #15268: URL: https://github.com/apache/datafusion/pull/15268#issuecomment-2733344214 Thank you all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Refactor file schema type coercions [datafusion]

2025-03-17 Thread via GitHub
xudong963 commented on code in PR #15268: URL: https://github.com/apache/datafusion/pull/15268#discussion_r2000307800 ## datafusion/datasource-parquet/src/file_format.rs: ## @@ -465,7 +465,116 @@ impl FileFormat for ParquetFormat { } } +/// Apply necessary schema type co

Re: [PR] Refactor file schema type coercions [datafusion]

2025-03-17 Thread via GitHub
jayzhan211 commented on code in PR #15268: URL: https://github.com/apache/datafusion/pull/15268#discussion_r2000156746 ## datafusion/datasource-parquet/src/file_format.rs: ## @@ -465,7 +465,116 @@ impl FileFormat for ParquetFormat { } } +/// Apply necessary schema type c

Re: [PR] Refactor file schema type coercions [datafusion]

2025-03-17 Thread via GitHub
xudong963 commented on code in PR #15268: URL: https://github.com/apache/datafusion/pull/15268#discussion_r2000109655 ## datafusion/datasource-parquet/src/file_format.rs: ## @@ -465,45 +465,103 @@ impl FileFormat for ParquetFormat { } } -/// Coerces the file schema if th

Re: [PR] Refactor file schema type coercions [datafusion]

2025-03-17 Thread via GitHub
m09526 commented on code in PR #15268: URL: https://github.com/apache/datafusion/pull/15268#discussion_r1998724986 ## datafusion/datasource-parquet/src/file_format.rs: ## @@ -465,45 +465,103 @@ impl FileFormat for ParquetFormat { } } -/// Coerces the file schema if the t

Re: [PR] Refactor file schema type coercions [datafusion]

2025-03-17 Thread via GitHub
alamb commented on code in PR #15268: URL: https://github.com/apache/datafusion/pull/15268#discussion_r1999148261 ## datafusion/datasource-parquet/src/file_format.rs: ## @@ -465,45 +465,103 @@ impl FileFormat for ParquetFormat { } } -/// Coerces the file schema if the ta

Re: [PR] Refactor file schema type coercions [datafusion]

2025-03-17 Thread via GitHub
xudong963 commented on code in PR #15268: URL: https://github.com/apache/datafusion/pull/15268#discussion_r1999040059 ## datafusion/datasource-parquet/src/file_format.rs: ## @@ -465,45 +465,103 @@ impl FileFormat for ParquetFormat { } } -/// Coerces the file schema if th