qstommyshu commented on code in PR #15621:
URL: https://github.com/apache/datafusion/pull/15621#discussion_r2031938054
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
@@ -509,219 +555,378 @@ fn roundtrip_statement_with_dialect() -> Result<()> {
) abc
qstommyshu commented on PR #15621:
URL: https://github.com/apache/datafusion/pull/15621#issuecomment-2784515058
> > I wrote a script to migrate the test
>
> Maybe you could attach your script here? So we can use it in the future if
we have a similar task again?
Not sure if it w
alamb commented on PR #15621:
URL: https://github.com/apache/datafusion/pull/15621#issuecomment-2785987722
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
alamb merged PR #15621:
URL: https://github.com/apache/datafusion/pull/15621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #15621:
URL: https://github.com/apache/datafusion/pull/15621#issuecomment-2784626521
> part7
I think this PR is a textbook example of how to make large scale
refactorings in a way that is reviewable and minimally disruptive. Great work
--
This is an autom
qstommyshu commented on PR #15621:
URL: https://github.com/apache/datafusion/pull/15621#issuecomment-2784304605
Hi @alamb and @blaginin ,
This PR is ready to review, please take a look once you have time.
--
This is an automated message from the Apache Git Service.
To respond to th
blaginin commented on PR #15621:
URL: https://github.com/apache/datafusion/pull/15621#issuecomment-2784433373
This is very cool! Will review now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
blaginin commented on PR #15621:
URL: https://github.com/apache/datafusion/pull/15621#issuecomment-2784472398
> I wrote a script to migrate the test
Maybe you could attach your script here? So we can use it in the future if
we have a similar task again?
--
This is an automated mes
blaginin commented on code in PR #15621:
URL: https://github.com/apache/datafusion/pull/15621#discussion_r2031911786
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
@@ -509,219 +555,378 @@ fn roundtrip_statement_with_dialect() -> Result<()> {
) abc
