Re: [PR] Map file-level column statistics to the table-level [datafusion]

2025-05-09 Thread via GitHub
adriangb commented on code in PR #15865: URL: https://github.com/apache/datafusion/pull/15865#discussion_r2082446025 ## datafusion/datasource/src/schema_adapter.rs: ## @@ -334,4 +340,126 @@ impl SchemaMapper for SchemaMapping { let record_batch = RecordBatch::try_new_wi

Re: [PR] Map file-level column statistics to the table-level [datafusion]

2025-05-09 Thread via GitHub
xudong963 commented on code in PR #15865: URL: https://github.com/apache/datafusion/pull/15865#discussion_r2082010143 ## datafusion/datasource/src/schema_adapter.rs: ## @@ -334,4 +340,126 @@ impl SchemaMapper for SchemaMapping { let record_batch = RecordBatch::try_new_w

Re: [PR] Map file-level column statistics to the table-level [datafusion]

2025-05-07 Thread via GitHub
adriangb commented on code in PR #15865: URL: https://github.com/apache/datafusion/pull/15865#discussion_r2077215405 ## datafusion/datasource/src/schema_adapter.rs: ## @@ -334,4 +340,126 @@ impl SchemaMapper for SchemaMapping { let record_batch = RecordBatch::try_new_wi

Re: [PR] Map file-level column statistics to the table-level [datafusion]

2025-04-29 Thread via GitHub
xudong963 commented on code in PR #15865: URL: https://github.com/apache/datafusion/pull/15865#discussion_r2065855163 ## datafusion/core/src/datasource/listing/table.rs: ## @@ -1129,7 +1130,17 @@ impl ListingTable { let (file_group, inexact_stats) = get_fil

Re: [PR] Map file-level column statistics to the table-level [datafusion]

2025-04-29 Thread via GitHub
xudong963 merged PR #15865: URL: https://github.com/apache/datafusion/pull/15865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@data

Re: [PR] Map file-level column statistics to the table-level [datafusion]

2025-04-29 Thread via GitHub
xudong963 commented on PR #15865: URL: https://github.com/apache/datafusion/pull/15865#issuecomment-2837714159 @alamb I'll merge the PR and continue to fix tests in https://github.com/apache/datafusion/pull/15852 -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Map file-level column statistics to the table-level [datafusion]

2025-04-28 Thread via GitHub
xudong963 commented on code in PR #15865: URL: https://github.com/apache/datafusion/pull/15865#discussion_r2065622070 ## datafusion/core/src/datasource/listing/table.rs: ## @@ -1129,7 +1130,17 @@ impl ListingTable { let (file_group, inexact_stats) = get_fil

Re: [PR] Map file-level column statistics to the table-level [datafusion]

2025-04-28 Thread via GitHub
xudong963 commented on PR #15865: URL: https://github.com/apache/datafusion/pull/15865#issuecomment-2837504538 > Can you please add a test that verifies the statistics of a ListingTable that was created with two parquet files of different schemas? I think you could write a SLT level test wi

Re: [PR] Map file-level column statistics to the table-level [datafusion]

2025-04-28 Thread via GitHub
alamb commented on code in PR #15865: URL: https://github.com/apache/datafusion/pull/15865#discussion_r2065156402 ## datafusion/core/src/datasource/listing/table.rs: ## @@ -1129,7 +1130,17 @@ impl ListingTable { let (file_group, inexact_stats) = get_files_w

Re: [PR] Map file-level column statistics to the table-level [datafusion]

2025-04-27 Thread via GitHub
xudong963 commented on PR #15865: URL: https://github.com/apache/datafusion/pull/15865#issuecomment-2833360326 Fyi @friendlymatthew -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c