Re: [PR] Implement tree explain for AggregateExec [datafusion]

2025-03-11 Thread via GitHub
alamb commented on PR #15103: URL: https://github.com/apache/datafusion/pull/15103#issuecomment-2715508162 I also tested that these tests pass on main after merging up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Implement tree explain for AggregateExec [datafusion]

2025-03-11 Thread via GitHub
alamb merged PR #15103: URL: https://github.com/apache/datafusion/pull/15103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Implement tree explain for AggregateExec [datafusion]

2025-03-11 Thread via GitHub
zebsme commented on code in PR #15103: URL: https://github.com/apache/datafusion/pull/15103#discussion_r1988851050 ## datafusion/physical-plan/src/aggregates/mod.rs: ## @@ -809,8 +809,60 @@ impl DisplayAs for AggregateExec { } } Display

Re: [PR] Implement tree explain for AggregateExec [datafusion]

2025-03-10 Thread via GitHub
Weijun-H commented on code in PR #15103: URL: https://github.com/apache/datafusion/pull/15103#discussion_r1988354902 ## datafusion/physical-plan/src/aggregates/mod.rs: ## @@ -809,8 +809,60 @@ impl DisplayAs for AggregateExec { } } Displ

Re: [PR] Implement tree explain for AggregateExec [datafusion]

2025-03-09 Thread via GitHub
alamb commented on code in PR #15103: URL: https://github.com/apache/datafusion/pull/15103#discussion_r1986382181 ## datafusion/physical-plan/src/aggregates/mod.rs: ## @@ -809,8 +809,54 @@ impl DisplayAs for AggregateExec { } } DisplayF

Re: [PR] Implement tree explain for AggregateExec [datafusion]

2025-03-09 Thread via GitHub
zebsme commented on code in PR #15103: URL: https://github.com/apache/datafusion/pull/15103#discussion_r1986332402 ## datafusion/physical-plan/src/aggregates/mod.rs: ## @@ -809,8 +809,54 @@ impl DisplayAs for AggregateExec { } } Display

Re: [PR] Implement tree explain for AggregateExec [datafusion]

2025-03-09 Thread via GitHub
alamb commented on code in PR #15103: URL: https://github.com/apache/datafusion/pull/15103#discussion_r1986313731 ## datafusion/sqllogictest/test_files/explain_tree.slt: ## @@ -124,25 +124,39 @@ logical_plan physical_plan 01)┌───┐ 02)│ AggregateE