Re: [PR] Fix join type coercion with anonymous types [datafusion]

2025-01-31 Thread via GitHub
alamb commented on PR #14387: URL: https://github.com/apache/datafusion/pull/14387#issuecomment-2628326714 > what are "anonymous types"? I am not sure I understand what you are referring to -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Fix join type coercion with anonymous types [datafusion]

2025-01-31 Thread via GitHub
findepi commented on PR #14387: URL: https://github.com/apache/datafusion/pull/14387#issuecomment-2628242449 what are "anonymous types"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Fix join type coercion with anonymous types [datafusion]

2025-01-31 Thread via GitHub
alamb commented on code in PR #14387: URL: https://github.com/apache/datafusion/pull/14387#discussion_r1937863007 ## datafusion/core/tests/dataframe/mod.rs: ## @@ -1121,6 +1121,39 @@ async fn join() -> Result<()> { Ok(()) } +#[tokio::test] +async fn join_coercion_unnname

Re: [PR] Fix join type coercion with anonymous types [datafusion]

2025-01-31 Thread via GitHub
rkrishn7 commented on code in PR #14387: URL: https://github.com/apache/datafusion/pull/14387#discussion_r1937641667 ## datafusion/core/tests/dataframe/mod.rs: ## @@ -1121,6 +1121,39 @@ async fn join() -> Result<()> { Ok(()) } +#[tokio::test] +async fn join_coercion_unnn

Re: [PR] Fix join type coercion with anonymous types [datafusion]

2025-01-31 Thread via GitHub
alamb commented on code in PR #14387: URL: https://github.com/apache/datafusion/pull/14387#discussion_r1937597947 ## datafusion/optimizer/src/analyzer/type_coercion.rs: ## @@ -190,7 +190,15 @@ impl<'a> TypeCoercionRewriter<'a> { .map(|(lhs, rhs)| {

Re: [PR] Fix join type coercion with anonymous types [datafusion]

2025-01-31 Thread via GitHub
rkrishn7 commented on code in PR #14387: URL: https://github.com/apache/datafusion/pull/14387#discussion_r1937632262 ## datafusion/core/tests/dataframe/mod.rs: ## @@ -1121,6 +1121,39 @@ async fn join() -> Result<()> { Ok(()) } +#[tokio::test] +async fn join_coercion_unnn