Re: [PR] Feat: support bit_get function [datafusion-comet]

2025-06-25 Thread via GitHub
comphead commented on code in PR #1713: URL: https://github.com/apache/datafusion-comet/pull/1713#discussion_r2167886851 ## spark/src/main/scala/org/apache/comet/serde/bitwise.scala: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] Feat: support bit_get function [datafusion-comet]

2025-06-25 Thread via GitHub
andygrove commented on PR #1713: URL: https://github.com/apache/datafusion-comet/pull/1713#issuecomment-3006591464 @kazantsev-maksim I took the liberty of upmering this PR @parthchandra @comphead could you take another look when you have a chance? -- This is an automated message fr

Re: [PR] Feat: support bit_get function [datafusion-comet]

2025-05-07 Thread via GitHub
parthchandra commented on PR #1713: URL: https://github.com/apache/datafusion-comet/pull/1713#issuecomment-2860273632 Same comment as in #1602 (https://github.com/apache/datafusion-comet/pull/1602#discussion_r2078442637) -- This is an automated message from the Apache Git Service. To res

Re: [PR] Feat: support bit_get function [datafusion-comet]

2025-05-05 Thread via GitHub
kazantsev-maksim commented on PR #1713: URL: https://github.com/apache/datafusion-comet/pull/1713#issuecomment-2851931381 @comphead I'd like to merge https://github.com/apache/datafusion-comet/pull/1602 first, and then update this PR again, but the reverse order is also fine. -- This is

Re: [PR] Feat: support bit_get function [datafusion-comet]

2025-05-05 Thread via GitHub
codecov-commenter commented on PR #1713: URL: https://github.com/apache/datafusion-comet/pull/1713#issuecomment-2851879847 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1713?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca