Re: [PR] Feat: support bit_count function [datafusion-comet]

kazuyukitanimura commented on PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#issuecomment-2923351378 Merged Thank you @kazantsev-maksim @parthchandra @mbutrovich -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Feat: support bit_count function [datafusion-comet]

kazuyukitanimura merged PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsub

Re: [PR] Feat: support bit_count function [datafusion-comet]

kazantsev-maksim commented on PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#issuecomment-2922907576 Thank you for the feedback! @kazuyukitanimura @parthchandra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Feat: support bit_count function [datafusion-comet]

parthchandra commented on code in PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#discussion_r2112886589 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -99,6 +100,73 @@ class CometExpressionSuite extends CometTestBase with Adaptiv

Re: [PR] Feat: support bit_count function [datafusion-comet]

kazantsev-maksim commented on code in PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#discussion_r2112325535 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -99,6 +100,73 @@ class CometExpressionSuite extends CometTestBase with Ada

Re: [PR] Feat: support bit_count function [datafusion-comet]

parthchandra commented on code in PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#discussion_r2110587829 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -90,6 +90,29 @@ class CometExpressionSuite extends CometTestBase with Adaptive

Re: [PR] Feat: support bit_count function [datafusion-comet]

kazantsev-maksim commented on code in PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#discussion_r2105148849 ## native/spark-expr/src/bitwise_funcs/bitwise_count.rs: ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

Re: [PR] Feat: support bit_count function [datafusion-comet]

kazuyukitanimura commented on code in PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#discussion_r2078943165 ## native/spark-expr/src/bitwise_funcs/bitwise_count.rs: ## @@ -0,0 +1,177 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

Re: [PR] Feat: support bit_count function [datafusion-comet]

parthchandra commented on code in PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#discussion_r2078437197 ## native/spark-expr/src/bitwise_funcs/bitwise_count.rs: ## @@ -0,0 +1,103 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

Re: [PR] Feat: support bit_count function [datafusion-comet]

kazantsev-maksim commented on PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#issuecomment-2844940964 @mbutrovich I couldn't find a built-in implementation of bit_count in the DataFusion project, but i rewrote it using scalarFunc without adding a new proto expr. -- T

Re: [PR] Feat: support bit_count function [datafusion-comet]

mbutrovich commented on PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#issuecomment-2843603389 > DataFusion's bit_count has same behavior with Spark 's bit_count function Spark If this is the case, can we delegate to a `ScalarFunc` expression instead of creating

Re: [PR] Feat: support bit_count function [datafusion-comet]

kazuyukitanimura commented on code in PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#discussion_r2069467729 ## native/spark-expr/src/bitwise_funcs/bitwise_count.rs: ## @@ -0,0 +1,177 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

Re: [PR] Feat: support bit_count function [datafusion-comet]

kazantsev-maksim commented on code in PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#discussion_r2064138880 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -90,6 +90,29 @@ class CometExpressionSuite extends CometTestBase with Adap

Re: [PR] Feat: support bit_count function [datafusion-comet]

kazuyukitanimura commented on code in PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#discussion_r2025487131 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -90,6 +90,29 @@ class CometExpressionSuite extends CometTestBase with Adap

Re: [PR] Feat: support bit_count function [datafusion-comet]

kazuyukitanimura commented on code in PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#discussion_r2025565665 ## native/spark-expr/src/bitwise_funcs/bitwise_count.rs: ## @@ -0,0 +1,172 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mo

Re: [PR] Feat: support bit_count function [datafusion-comet]

codecov-commenter commented on PR #1602: URL: https://github.com/apache/datafusion-comet/pull/1602#issuecomment-2773591428 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1602?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca