andygrove merged PR #1343:
URL: https://github.com/apache/datafusion-comet/pull/1343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
andygrove commented on PR #1343:
URL:
https://github.com/apache/datafusion-comet/pull/1343#issuecomment-2771256823
Thanks @kazantsev-maksim
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
kazantsev-maksim commented on PR #1343:
URL:
https://github.com/apache/datafusion-comet/pull/1343#issuecomment-2758802302
So far, I haven’t been able to reproduce the failing tests on a similar
environment setup on my machine.
--
This is an automated message from the Apache Git Service.
kazuyukitanimura commented on PR #1343:
URL:
https://github.com/apache/datafusion-comet/pull/1343#issuecomment-2657641667
@kazantsev-maksim it seems there are test failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kazantsev-maksim commented on PR #1343:
URL:
https://github.com/apache/datafusion-comet/pull/1343#issuecomment-2654088772
Thanks @kazuyukitanimura. I've fixed the formatting in the `native` module
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
kazuyukitanimura commented on PR #1343:
URL:
https://github.com/apache/datafusion-comet/pull/1343#issuecomment-2651649936
Looks there are some format issues need to be fixed @kazantsev-maksim
otherwise I think it is good to go
--
This is an automated message from the Apache Git Service.
kazantsev-maksim commented on code in PR #1343:
URL: https://github.com/apache/datafusion-comet/pull/1343#discussion_r1951283164
##
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##
@@ -292,4 +292,89 @@ class CometArrayExpressionSuite extends CometTestBas
kazantsev-maksim commented on code in PR #1343:
URL: https://github.com/apache/datafusion-comet/pull/1343#discussion_r1951269786
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2387,6 +2387,8 @@ object QueryPlanSerde extends Logging with
ShimQueryPla
kazuyukitanimura commented on code in PR #1343:
URL: https://github.com/apache/datafusion-comet/pull/1343#discussion_r1949694482
##
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##
@@ -292,4 +292,89 @@ class CometArrayExpressionSuite extends CometTestBas
kazuyukitanimura commented on code in PR #1343:
URL: https://github.com/apache/datafusion-comet/pull/1343#discussion_r1949690727
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2387,6 +2387,8 @@ object QueryPlanSerde extends Logging with
ShimQueryPla
kazantsev-maksim commented on code in PR #1343:
URL: https://github.com/apache/datafusion-comet/pull/1343#discussion_r1947893539
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2387,6 +2387,8 @@ object QueryPlanSerde extends Logging with
ShimQueryPla
kazantsev-maksim commented on code in PR #1343:
URL: https://github.com/apache/datafusion-comet/pull/1343#discussion_r1947892464
##
spark/src/main/scala/org/apache/comet/serde/arrays.scala:
##
@@ -126,6 +126,21 @@ object CometArraysOverlap extends CometExpressionSerde
with Inco
kazantsev-maksim commented on code in PR #1343:
URL: https://github.com/apache/datafusion-comet/pull/1343#discussion_r1947891630
##
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##
@@ -292,4 +292,89 @@ class CometArrayExpressionSuite extends CometTestBas
kazuyukitanimura commented on code in PR #1343:
URL: https://github.com/apache/datafusion-comet/pull/1343#discussion_r1943711444
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2387,6 +2387,8 @@ object QueryPlanSerde extends Logging with
ShimQueryPla
kazantsev-maksim commented on code in PR #1343:
URL: https://github.com/apache/datafusion-comet/pull/1343#discussion_r1932434647
##
native/core/src/execution/planner.rs:
##
@@ -818,6 +819,22 @@ impl PhysicalPlanner {
));
Ok(array_join_expr)
codecov-commenter commented on PR #1343:
URL:
https://github.com/apache/datafusion-comet/pull/1343#issuecomment-2616736897
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1343?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
16 matches
Mail list logo
