Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2248445838 ## src/dialect/mod.rs: ## @@ -1036,8 +1036,14 @@ pub trait Dialect: Debug + Any { /// Returns true if the specified keyword should be parsed as

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2248418391 ## src/parser/mod.rs: ## @@ -266,6 +266,22 @@ impl ParserOptions { self.unescape = unescape; self } + +/// Set if semicolo

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2248411515 ## src/parser/mod.rs: ## @@ -16464,7 +16505,28 @@ impl<'a> Parser<'a> { /// Parse [Statement::Return] fn parse_return(&mut self) -> Resul

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

iffyio commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2247708131 ## src/dialect/mod.rs: ## @@ -1036,8 +1036,14 @@ pub trait Dialect: Debug + Any { /// Returns true if the specified keyword should be parsed as a t

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220450277 ## src/parser/mod.rs: ## @@ -485,10 +505,10 @@ impl<'a> Parser<'a> { match self.peek_token().token { Token::EOF => brea

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220449729 ## src/parser/mod.rs: ## @@ -4541,6 +4561,18 @@ impl<'a> Parser<'a> { return Ok(vec![]); } +if end_token == Token::Se

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220448930 ## src/dialect/mssql.rs: ## @@ -123,6 +123,10 @@ impl Dialect for MsSqlDialect { true } +fn supports_statements_without_semicolon

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220436802 ## src/dialect/mod.rs: ## @@ -1136,6 +1142,11 @@ pub trait Dialect: Debug + Any { fn supports_notnull_operator(&self) -> bool { false

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220434233 ## src/test_utils.rs: ## @@ -186,6 +187,37 @@ impl TestedDialects { statements } +/// The same as [`statements_parse_to`] but it

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220430113 ## src/parser/mod.rs: ## @@ -16464,7 +16505,28 @@ impl<'a> Parser<'a> { /// Parse [Statement::Return] fn parse_return(&mut self) -> Resul

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220368348 ## src/parser/mod.rs: ## @@ -4541,6 +4561,18 @@ impl<'a> Parser<'a> { return Ok(vec![]); } +if end_token == Token::Se

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220366992 ## src/parser/mod.rs: ## @@ -266,6 +266,22 @@ impl ParserOptions { self.unescape = unescape; self } + +/// Set if semicolo

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220351888 ## tests/sqlparser_common.rs: ## @@ -272,20 +275,39 @@ fn parse_insert_default_values() { "INSERT INTO test_table DEFAULT VALUES (some_colum

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220337141 ## src/test_utils.rs: ## @@ -186,6 +187,37 @@ impl TestedDialects { statements } +/// The same as [`statements_parse_to`] but it

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2220333518 ## src/parser/mod.rs: ## @@ -485,10 +505,10 @@ impl<'a> Parser<'a> { match self.peek_token().token { Token::EOF => brea

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

alamb commented on code in PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#discussion_r2219942253 ## src/parser/mod.rs: ## @@ -266,6 +266,22 @@ impl ParserOptions { self.unescape = unescape; self } + +/// Set if semicolon st

Re: [PR] Expand parse without semicolons [datafusion-sqlparser-rs]

aharpervc commented on PR #1949: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1949#issuecomment-3079970637 @alamb fyi, [as previously discussed](https://github.com/apache/datafusion-sqlparser-rs/pull/1937#issuecomment-3070806780) -- This is an automated message from the Ap