jayzhan211 merged PR #15726:
URL: https://github.com/apache/datafusion/pull/15726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
jayzhan211 commented on PR #15726:
URL: https://github.com/apache/datafusion/pull/15726#issuecomment-2814290610
Thanks @leoyvens @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
alamb commented on code in PR #15726:
URL: https://github.com/apache/datafusion/pull/15726#discussion_r2049064058
##
datafusion/expr-common/src/type_coercion/binary.rs:
##
@@ -1297,6 +1297,10 @@ fn binary_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option
leoyvens commented on PR #15726:
URL: https://github.com/apache/datafusion/pull/15726#issuecomment-2809641963
cc @jayzhan211, could I ask you for a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
leoyvens commented on PR #15726:
URL: https://github.com/apache/datafusion/pull/15726#issuecomment-2809573254
I now realize I the `ExprSimplifier` case I added was entirely redundant
with the `unwrap_cast_in_comparison` case. I've removed it and just kept the
coercion and test cases.
--
