Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-31 Thread via GitHub
2010YOUY01 commented on PR #16819: URL: https://github.com/apache/datafusion/pull/16819#issuecomment-3140388598 Move to the final PR https://github.com/apache/datafusion/pull/16996, so closing this one. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-31 Thread via GitHub
2010YOUY01 closed pull request #16819: Benchmark: Add micro-benchmark for Nested Loop Join operator URL: https://github.com/apache/datafusion/pull/16819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-24 Thread via GitHub
2010YOUY01 commented on PR #16819: URL: https://github.com/apache/datafusion/pull/16819#issuecomment-3116228640 > It might be helpful to add a brief description in `benchmarks/README.md`. Also, once this PR is merged, I'll follow up by adding nlj benchmarks to the memory profiling utility (

Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-24 Thread via GitHub
ding-young commented on PR #16819: URL: https://github.com/apache/datafusion/pull/16819#issuecomment-3115960659 It might be helpful to add a brief description in `benchmarks/README.md`. Also, once this PR is merged, I'll follow up by adding nlj benchmarks to the memory profiling utility (in

Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-19 Thread via GitHub
UBarney commented on code in PR #16819: URL: https://github.com/apache/datafusion/pull/16819#discussion_r2217234281 ## benchmarks/src/nlj.rs: ## @@ -0,0 +1,228 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the

Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-19 Thread via GitHub
2010YOUY01 commented on code in PR #16819: URL: https://github.com/apache/datafusion/pull/16819#discussion_r2217241769 ## benchmarks/src/nlj.rs: ## @@ -0,0 +1,228 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See t

Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-18 Thread via GitHub
2010YOUY01 commented on PR #16819: URL: https://github.com/apache/datafusion/pull/16819#issuecomment-3091475027 Thank you for the review @UBarney @jonathanc-n -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-18 Thread via GitHub
2010YOUY01 commented on PR #16819: URL: https://github.com/apache/datafusion/pull/16819#issuecomment-3091474891 > @2010YOUY01 Thanks for providing such a comprehensive set of benchmark cases. It would be even better if it could also output the memory consumption for each SQL query, just lik

Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-18 Thread via GitHub
2010YOUY01 commented on code in PR #16819: URL: https://github.com/apache/datafusion/pull/16819#discussion_r2217129111 ## benchmarks/src/nlj.rs: ## @@ -0,0 +1,244 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See t

Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-18 Thread via GitHub
2010YOUY01 commented on code in PR #16819: URL: https://github.com/apache/datafusion/pull/16819#discussion_r2217129149 ## benchmarks/src/nlj.rs: ## @@ -0,0 +1,244 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See t

Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-18 Thread via GitHub
UBarney commented on code in PR #16819: URL: https://github.com/apache/datafusion/pull/16819#discussion_r2216202985 ## benchmarks/src/nlj.rs: ## @@ -0,0 +1,244 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the

Re: [PR] Benchmark: Add micro-benchmark for Nested Loop Join operator [datafusion]

2025-07-18 Thread via GitHub
jonathanc-n commented on PR #16819: URL: https://github.com/apache/datafusion/pull/16819#issuecomment-3089640810 Recorded existence join work at #16820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to